Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: emachado@linux.vnet.ibm.com (Edjunior Barbosa Machado)
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] testsuite: Fix gdb.dwarf2/dw2-case-insensitive.exp testcase for ppc64
Date: Tue, 28 Jan 2014 16:01:00 -0000	[thread overview]
Message-ID: <201401281601.s0SG1lJW004119@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <1390488123-2421-1-git-send-email-emachado@linux.vnet.ibm.com> from "Edjunior Barbosa Machado" at Jan 23, 2014 12:42:02 PM

Edjunior Barbosa Machado wrote:

> gdb.dwarf2/dw2-case-insensitive.exp has currently 1 test failing on ppc64:
> 
> p fuNC_symtab^M
> $2 = {<text variable, no debug info>} 0x10000694 <FUNC_lang_end>^M
> (gdb) FAIL: gdb.dwarf2/dw2-case-insensitive.exp: p fuNC_symtab

So I guess this happens because FUNC_lang_end ends up at the same address
as FUNC_symtab?

> This patch moves the label FUNC_lang_end to the end of the function scope, so
> ppc64 can understand the following function (fuNC_symtab) correctly.

I'm not sure if this is the correct fix ... the DWARF end label really should
come after all the code in the function.

If the problem is indeed that FUNC_lang_end is at the same location as
FUNC_symtab, maybe a better fix would be to add some padding in between
(e.g. a ".byte 0" after the FUNC_lang_end label)?

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain
  Ulrich.Weigand@de.ibm.com


  parent reply	other threads:[~2014-01-28 16:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-23 14:42 Edjunior Barbosa Machado
2014-01-23 15:54 ` Will Newton
2014-01-28 16:01 ` Ulrich Weigand [this message]
2014-01-28 18:20   ` Edjunior Barbosa Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201401281601.s0SG1lJW004119@d06av02.portsmouth.uk.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=emachado@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox