From: Pedro Alves <palves@redhat.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: gdb-patches@sourceware.org, Maxim Grigoriev <maxim2405@gmail.com>,
Marc Gauthier <marc@cadence.com>,
Dror Maydan <maydan@cadence.com>,
Woody LaRue <larue@cadence.com>,
Chris Zankel <chris@zankel.net>
Subject: Re: [PATCH v2] gdb: xtensa: fix linux ptrace includes
Date: Mon, 20 Jan 2014 12:20:00 -0000 [thread overview]
Message-ID: <52DD0D6C.1040309@redhat.com> (raw)
In-Reply-To: <b244a41787db2076a979c4e18532e51ffc47bb58.1390117992.git.baruch@tkos.co.il>
On 01/19/2014 07:53 AM, Baruch Siach wrote:
> Currently, xtensa code using the Linux ptrace interface only include
> sys/ptrace.h. This file comes from the C library (glibc and uClibc, at least),
> and includes a declaration of the ptrace() functions, along with some cross
> architecture constants that are mostly copied from the file located at
> include/uapi/linux/ptrace.h in recent Linux kernels.
>
> For xtensa specific constants like PTRACE_GETXTREGS and PTRACE_SETXTREGS the
> asm/ptrace.h include from the Linux kernel UAPI is needed. The code in
> gdbserver xtensa specific part doesn't call ptrace() directly, so we can
> remove the unneeded sys/ptrace.h include. The gdb xtensa specific code needs
> both headers, since it calls ptrace().
>
Pushed, thanks.
--
Pedro Alves
next prev parent reply other threads:[~2014-01-20 12:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-19 7:53 Baruch Siach
2014-01-20 12:20 ` Pedro Alves [this message]
2014-01-22 4:52 ` Baruch Siach
2014-01-22 12:36 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DD0D6C.1040309@redhat.com \
--to=palves@redhat.com \
--cc=baruch@tkos.co.il \
--cc=chris@zankel.net \
--cc=gdb-patches@sourceware.org \
--cc=larue@cadence.com \
--cc=marc@cadence.com \
--cc=maxim2405@gmail.com \
--cc=maydan@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox