From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31351 invoked by alias); 20 Jan 2014 12:20:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31333 invoked by uid 89); 20 Jan 2014 12:20:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Jan 2014 12:20:39 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0KCKYUv018491 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 20 Jan 2014 07:20:34 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0KBo5Ae024954; Mon, 20 Jan 2014 06:50:06 -0500 Message-ID: <52DD0D6C.1040309@redhat.com> Date: Mon, 20 Jan 2014 12:20:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Baruch Siach CC: gdb-patches@sourceware.org, Maxim Grigoriev , Marc Gauthier , Dror Maydan , Woody LaRue , Chris Zankel Subject: Re: [PATCH v2] gdb: xtensa: fix linux ptrace includes References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-01/txt/msg00740.txt.bz2 On 01/19/2014 07:53 AM, Baruch Siach wrote: > Currently, xtensa code using the Linux ptrace interface only include > sys/ptrace.h. This file comes from the C library (glibc and uClibc, at least), > and includes a declaration of the ptrace() functions, along with some cross > architecture constants that are mostly copied from the file located at > include/uapi/linux/ptrace.h in recent Linux kernels. > > For xtensa specific constants like PTRACE_GETXTREGS and PTRACE_SETXTREGS the > asm/ptrace.h include from the Linux kernel UAPI is needed. The code in > gdbserver xtensa specific part doesn't call ptrace() directly, so we can > remove the unneeded sys/ptrace.h include. The gdb xtensa specific code needs > both headers, since it calls ptrace(). > Pushed, thanks. -- Pedro Alves