From: Baruch Siach <baruch@tkos.co.il>
To: gdb-patches@sourceware.org
Cc: Pedro Alves <palves@redhat.com>,
Maxim Grigoriev <maxim2405@gmail.com>,
Marc Gauthier <marc@cadence.com>,
Dror Maydan <maydan@cadence.com>, Woody LaRue <larue@cadence.com>,
Chris Zankel <chris@zankel.net>, Baruch Siach <baruch@tkos.co.il>
Subject: [PATCH v2] gdb: xtensa: fix linux ptrace includes
Date: Sun, 19 Jan 2014 07:53:00 -0000 [thread overview]
Message-ID: <b244a41787db2076a979c4e18532e51ffc47bb58.1390117992.git.baruch@tkos.co.il> (raw)
Currently, xtensa code using the Linux ptrace interface only include
sys/ptrace.h. This file comes from the C library (glibc and uClibc, at least),
and includes a declaration of the ptrace() functions, along with some cross
architecture constants that are mostly copied from the file located at
include/uapi/linux/ptrace.h in recent Linux kernels.
For xtensa specific constants like PTRACE_GETXTREGS and PTRACE_SETXTREGS the
asm/ptrace.h include from the Linux kernel UAPI is needed. The code in
gdbserver xtensa specific part doesn't call ptrace() directly, so we can
remove the unneeded sys/ptrace.h include. The gdb xtensa specific code needs
both headers, since it calls ptrace().
gdb/
* xtensa-linux-nat.c: add #include asm/ptrace.h.
gdb/gdbserver/
* linux-xtensa-low.c: #include asm/ptrace.h instead of sys/ptrace.h.
---
gdb/gdbserver/linux-xtensa-low.c | 2 +-
gdb/xtensa-linux-nat.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/gdb/gdbserver/linux-xtensa-low.c b/gdb/gdbserver/linux-xtensa-low.c
index 7db97a9..479b65b 100644
--- a/gdb/gdbserver/linux-xtensa-low.c
+++ b/gdb/gdbserver/linux-xtensa-low.c
@@ -24,7 +24,7 @@
void init_registers_xtensa (void);
extern const struct target_desc *tdesc_xtensa;
-#include <sys/ptrace.h>
+#include <asm/ptrace.h>
#include <xtensa-config.h>
#include "xtensa-xtregs.c"
diff --git a/gdb/xtensa-linux-nat.c b/gdb/xtensa-linux-nat.c
index 2372e79..9340c62 100644
--- a/gdb/xtensa-linux-nat.c
+++ b/gdb/xtensa-linux-nat.c
@@ -36,6 +36,7 @@
#include <fcntl.h>
#include <sys/procfs.h>
#include <sys/ptrace.h>
+#include <asm/ptrace.h>
#include "gregset.h"
#include "xtensa-tdep.h"
--
1.8.5.2
next reply other threads:[~2014-01-19 7:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-19 7:53 Baruch Siach [this message]
2014-01-20 12:20 ` Pedro Alves
2014-01-22 4:52 ` Baruch Siach
2014-01-22 12:36 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b244a41787db2076a979c4e18532e51ffc47bb58.1390117992.git.baruch@tkos.co.il \
--to=baruch@tkos.co.il \
--cc=chris@zankel.net \
--cc=gdb-patches@sourceware.org \
--cc=larue@cadence.com \
--cc=marc@cadence.com \
--cc=maxim2405@gmail.com \
--cc=maydan@cadence.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox