Re: [PATCH] Add comments to gdbarch_address_class_name_to_type_flags

[Simon Marchi <simon.marchi@ericsson.com>]

On 14-01-16 02:26 PM, Pedro Alves wrote:
> On 01/16/2014 07:21 PM, Sergio Durigan Junior wrote:
>> On Thursday, January 16 2014, Pedro Alves wrote:
>>
>>> On 01/16/2014 06:47 PM, Simon Marchi wrote:
>>>> +/* Return the appropriate type_flags for the supplied address class.
>>>> +   This function should return 1 if the address class was recognized and
>>>> +   type_flags was set, zero otherwise.
>>>
>>> Say true/false instead of 1/zero.
>>
>> Sorry, but don't you think this is too nitpicking?  And is also the
>> first time I remember seeing such requirement.  I myself use "1/zero"
>> all the time, and I don't think this is an issue at all.
> 
> It's really GDB's style throughout.  It's not a big issue, and
> I'd really let it go if I didn't have any other comments.  But since
> I was making other comments, I took the opportunity to point that
> out.  Really not to be picky at all, but to take the chance
> to educate on GDB's style.
> 
>> But I don't want to be meta-nitpicking, of course.
> 
> Well, you sort of are.  ;-)
> 

I'm ok with that. Actually, I looked around to try to keep the same style, but I stumbled upon a "bad" example :P