From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>,
GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Add comments to gdbarch_address_class_name_to_type_flags
Date: Thu, 16 Jan 2014 19:21:00 -0000 [thread overview]
Message-ID: <m3bnzbag2n.fsf@redhat.com> (raw)
In-Reply-To: <52D82EDF.5010402@redhat.com> (Pedro Alves's message of "Thu, 16 Jan 2014 19:11:27 +0000")
On Thursday, January 16 2014, Pedro Alves wrote:
> On 01/16/2014 06:47 PM, Simon Marchi wrote:
>> +/* Return the appropriate type_flags for the supplied address class.
>> + This function should return 1 if the address class was recognized and
>> + type_flags was set, zero otherwise.
>
> Say true/false instead of 1/zero.
Sorry, but don't you think this is too nitpicking? And is also the
first time I remember seeing such requirement. I myself use "1/zero"
all the time, and I don't think this is an issue at all.
But I don't want to be meta-nitpicking, of course.
--
Sergio
next prev parent reply other threads:[~2014-01-16 19:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 18:47 Simon Marchi
2014-01-16 19:11 ` Pedro Alves
2014-01-16 19:21 ` Sergio Durigan Junior [this message]
2014-01-16 19:26 ` Pedro Alves
2014-01-16 19:32 ` Simon Marchi
2014-01-16 19:45 ` Sergio Durigan Junior
2014-01-16 19:58 ` Pedro Alves
2014-01-16 20:12 ` Tom Tromey
2014-01-16 19:31 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3bnzbag2n.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox