From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6928 invoked by alias); 16 Jan 2014 19:32:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6886 invoked by uid 89); 16 Jan 2014 19:32:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 16 Jan 2014 19:32:34 +0000 Received: from EUSAAHC007.ericsson.se (Unknown_Domain [147.117.188.93]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 6B.D8.23183.DC338D25; Thu, 16 Jan 2014 20:32:29 +0100 (CET) Received: from [142.133.110.254] (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.93) with Microsoft SMTP Server (TLS) id 14.2.347.0; Thu, 16 Jan 2014 14:32:31 -0500 Message-ID: <52D833E8.8090308@ericsson.com> Date: Thu, 16 Jan 2014 19:32:00 -0000 From: Simon Marchi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Pedro Alves CC: Sergio Durigan Junior , GDB Patches Subject: Re: [PATCH] Add comments to gdbarch_address_class_name_to_type_flags References: <52D8293B.6060701@ericsson.com> <52D82EDF.5010402@redhat.com> <52D8327D.7010403@redhat.com> In-Reply-To: <52D8327D.7010403@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00649.txt.bz2 On 14-01-16 02:26 PM, Pedro Alves wrote: > On 01/16/2014 07:21 PM, Sergio Durigan Junior wrote: >> On Thursday, January 16 2014, Pedro Alves wrote: >> >>> On 01/16/2014 06:47 PM, Simon Marchi wrote: >>>> +/* Return the appropriate type_flags for the supplied address class. >>>> + This function should return 1 if the address class was recognized and >>>> + type_flags was set, zero otherwise. >>> >>> Say true/false instead of 1/zero. >> >> Sorry, but don't you think this is too nitpicking? And is also the >> first time I remember seeing such requirement. I myself use "1/zero" >> all the time, and I don't think this is an issue at all. > > It's really GDB's style throughout. It's not a big issue, and > I'd really let it go if I didn't have any other comments. But since > I was making other comments, I took the opportunity to point that > out. Really not to be picky at all, but to take the chance > to educate on GDB's style. > >> But I don't want to be meta-nitpicking, of course. > > Well, you sort of are. ;-) > I'm ok with that. Actually, I looked around to try to keep the same style, but I stumbled upon a "bad" example :P