From: asmwarrior <asmwarrior@gmail.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFC, doc] fix document error on the grammar of GDB/MI output format syntax
Date: Mon, 23 Dec 2013 01:18:00 -0000 [thread overview]
Message-ID: <52B78F2D.4010103@gmail.com> (raw)
In-Reply-To: <20131223004146.GB4605@adacore.com>
On 2013-12-23 8:41, Joel Brobecker wrote:
>> Looking at your patch.
>>> -@code{[ @var{token} ] "+" @var{async-output}}
>>> +@code{[ @var{token} ] "+" @var{async-output}} @var{nl}
>> Is it OK to put the @var{nl} inside the @code{}?
>
> OK, thank you and Eli for pointing this out and confirming it.
> Attached is the updated patch.
>
>> Because I see some (removed) code in your patch:
>>> -@code{@var{async-class} ( "," @var{result} )* @var{nl}}
>> I'm not familiar with the Texinfo grammar.
>
> I won't say that I am extremely comfortable with it, yet,
> but I'm slowly getting there...
>
> Basically, the "nl" has been moved to the varous rules that
> use this rule (exec-async-output, status-async-output and
> notify-async-output). The idea is, as hinted in the patch's
> rev log, to keep the special symbol indicating the type of
> output, and the nl, within the same rule.
>
> gdb/doc/ChangeLog:
>
> (from Yao Qi <yao@codesourcery.com>)
Mistake here? Wrong person?
> (from Joel Brobecker <brobecker@adacore.com>)
> * gdb.texinfo (GDB/MI Output Syntax): Add some missing "nl"
> markers. Remove one that was misplaced.
>
> OK to apply?
>
I'm OK.
Yuanhui Zhang
next prev parent reply other threads:[~2013-12-23 1:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-22 7:38 asmwarrior
2013-12-22 8:09 ` Joel Brobecker
2013-12-22 11:33 ` asmwarrior
2013-12-22 16:18 ` Eli Zaretskii
2013-12-23 0:41 ` Joel Brobecker
2013-12-23 1:18 ` asmwarrior [this message]
2013-12-23 1:29 ` Joel Brobecker
2013-12-23 1:39 ` asmwarrior
2014-01-15 12:23 ` [pushed] " Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B78F2D.4010103@gmail.com \
--to=asmwarrior@gmail.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox