From: Joel Brobecker <brobecker@adacore.com>
To: asmwarrior <asmwarrior@gmail.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFC, doc] fix document error on the grammar of GDB/MI output format syntax
Date: Sun, 22 Dec 2013 08:09:00 -0000 [thread overview]
Message-ID: <20131222080903.GA4605@adacore.com> (raw)
In-Reply-To: <52B69693.10107@gmail.com>
> The change log could be: Fix syntax description error about GDB/MI "out-of-band-record", there should be a "new line" in end.
>
> Thanks.
>
> Yuanhui Zhang
I may have given you bad advice when we discussed this on gdb@.
Looking at the patch, I see you're repeating the "nl", which
was what I thought we could avoid. But now that we're trying to
implement the suggestion, and re-reading the grammar, it might
make better logical sense to group the marker used for a given
output report (Eg: "*" or "=") and the associated nl in the same
rule.
Concretely, this is the patch I would suggest instead (you'll notice
that I removed one such "nl") to move it elsewhere. I think it's an
extension of what you originally suggested?
Sorry about flip-flopping on you like that...
--
Joel
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index b7551c2..f392733 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -29166,16 +29166,16 @@ corresponding output for that command will also be prefixed by that same
@code{@var{exec-async-output} | @var{status-async-output} | @var{notify-async-output}}
@item @var{exec-async-output} @expansion{}
-@code{[ @var{token} ] "*" @var{async-output}}
+@code{[ @var{token} ] "*" @var{async-output}} @var{nl}
@item @var{status-async-output} @expansion{}
-@code{[ @var{token} ] "+" @var{async-output}}
+@code{[ @var{token} ] "+" @var{async-output}} @var{nl}
@item @var{notify-async-output} @expansion{}
-@code{[ @var{token} ] "=" @var{async-output}}
+@code{[ @var{token} ] "=" @var{async-output}} @var{nl}
@item @var{async-output} @expansion{}
-@code{@var{async-class} ( "," @var{result} )* @var{nl}}
+@code{@var{async-class} ( "," @var{result} )*
@item @var{result-class} @expansion{}
@code{"done" | "running" | "connected" | "error" | "exit"}
@@ -29207,13 +29207,13 @@ depending on the needs---this is still in development).
@code{@var{console-stream-output} | @var{target-stream-output} | @var{log-stream-output}}
@item @var{console-stream-output} @expansion{}
-@code{"~" @var{c-string}}
+@code{"~" @var{c-string}} @var{nl}
@item @var{target-stream-output} @expansion{}
-@code{"@@" @var{c-string}}
+@code{"@@" @var{c-string}} @var{nl}
@item @var{log-stream-output} @expansion{}
-@code{"&" @var{c-string}}
+@code{"&" @var{c-string}} @var{nl}
@item @var{nl} @expansion{}
@code{CR | CR-LF}
next prev parent reply other threads:[~2013-12-22 8:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-22 7:38 asmwarrior
2013-12-22 8:09 ` Joel Brobecker [this message]
2013-12-22 11:33 ` asmwarrior
2013-12-22 16:18 ` Eli Zaretskii
2013-12-23 0:41 ` Joel Brobecker
2013-12-23 1:18 ` asmwarrior
2013-12-23 1:29 ` Joel Brobecker
2013-12-23 1:39 ` asmwarrior
2014-01-15 12:23 ` [pushed] " Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131222080903.GA4605@adacore.com \
--to=brobecker@adacore.com \
--cc=asmwarrior@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox