From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5885 invoked by alias); 23 Dec 2013 01:18:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5872 invoked by uid 89); 23 Dec 2013 01:18:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f48.google.com Received: from mail-pa0-f48.google.com (HELO mail-pa0-f48.google.com) (209.85.220.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 23 Dec 2013 01:18:55 +0000 Received: by mail-pa0-f48.google.com with SMTP id rd3so4752754pab.35 for ; Sun, 22 Dec 2013 17:18:54 -0800 (PST) X-Received: by 10.66.163.74 with SMTP id yg10mr22749075pab.57.1387761534117; Sun, 22 Dec 2013 17:18:54 -0800 (PST) Received: from [192.168.1.103] ([115.206.104.230]) by mx.google.com with ESMTPSA id i10sm39526627pat.11.2013.12.22.17.18.50 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 22 Dec 2013 17:18:53 -0800 (PST) Message-ID: <52B78F2D.4010103@gmail.com> Date: Mon, 23 Dec 2013 01:18:00 -0000 From: asmwarrior User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Joel Brobecker CC: "gdb-patches@sourceware.org" Subject: Re: [RFC, doc] fix document error on the grammar of GDB/MI output format syntax References: <52B69693.10107@gmail.com> <20131222080903.GA4605@adacore.com> <52B6CDAB.1020303@gmail.com> <20131223004146.GB4605@adacore.com> In-Reply-To: <20131223004146.GB4605@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-12/txt/msg00868.txt.bz2 On 2013-12-23 8:41, Joel Brobecker wrote: >> Looking at your patch. >>> -@code{[ @var{token} ] "+" @var{async-output}} >>> +@code{[ @var{token} ] "+" @var{async-output}} @var{nl} >> Is it OK to put the @var{nl} inside the @code{}? > > OK, thank you and Eli for pointing this out and confirming it. > Attached is the updated patch. > >> Because I see some (removed) code in your patch: >>> -@code{@var{async-class} ( "," @var{result} )* @var{nl}} >> I'm not familiar with the Texinfo grammar. > > I won't say that I am extremely comfortable with it, yet, > but I'm slowly getting there... > > Basically, the "nl" has been moved to the varous rules that > use this rule (exec-async-output, status-async-output and > notify-async-output). The idea is, as hinted in the patch's > rev log, to keep the special symbol indicating the type of > output, and the nl, within the same rule. > > gdb/doc/ChangeLog: > > (from Yao Qi ) Mistake here? Wrong person? > (from Joel Brobecker ) > * gdb.texinfo (GDB/MI Output Syntax): Add some missing "nl" > markers. Remove one that was misplaced. > > OK to apply? > I'm OK. Yuanhui Zhang