Re: [PATCH 0/2] GDB process record and reverse debugging improvements for arm*-linux*

[Pedro Alves <palves@redhat.com>]

On 11/24/2013 11:48 PM, Omair Javaid wrote:

> After incorporating all suggestions I am posting a final version of all 
> three patches posted earlier. Looking for a go ahead for commit.

All three emails in the series have the same subject apart from
the numbers, which make it confusing.  It'd be good if you made
sure the subjects were actually different, and more specific,
in the git commit log.

Hmm, I'm also surprised to now find that this "0/2" email
actually contains a patch.  That makes it actually 3 patches
in the series.  This is not the standard de facto way to
send a series.  The best way is for 0 to be the series intro,
with no patch, and then have the patches be replies to the
intro mail.  (I'd suggest addressing the comments I just
sent to patches #1 and #2, and resend the whole series with
git send-mail, which does that for you automatically.)

> 
> == PATCH 0 ==
> 
> This patch adds a news entry about improved process record-replay on
> arm*-linux* targets.
> It also adds linux-record.o to gdb_target_obs in configure.tgt and
> enables gdb.reverse testsuite for arm*-linux* targets.

These could be two separate patches, with NEWS actually being the
last patch in the whole series.

> gdb/testsuite:
> 
> 2013-10-24  Omair Javaid  <omair.javaid@linaro.org>
> 
> 	* lib/gdb.exp: Enable gdb.reverse testsuite for arm*-linux* targets.

Write:

 	* lib/gdb.exp (supports_process_record): Return true for arm*-linux*.

Otherwise looks good.

-- 
Pedro Alves