Re: [PATCH 0/2] GDB process record and reverse debugging improvements for arm*-linux*

[Omair Javaid <omair.javaid@linaro.org>]

On Mon 11 Nov 2013 01:24:06 PM PKT, Omair Javaid wrote:
> On Fri 08 Nov 2013 01:18:45 PM PKT, oza Pawandeep wrote:
>> Hi,
>>
>> The previous support for arm instruction and thumb instruction for
>> record and reply was added by me.
>> but there some reverse test case failing...
>> I had issues with employer disclaimer, so could not proceed.
>> I have got the disclaimer now and is up-to date with FSF.
>>
>> some of the queries to you regarding thumb2 support ?
>>
>> 1) did you bring in co processor and dsp instruction support for thumb2 ?
>>
>> 2) can you please run gdb-rever test suite and see if your code passes
>> the same ?
>>
>>
>> Regards,
>> Oza.
>>
>>
>> On Fri, Nov 8, 2013 at 12:55 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>>>
>>>> Date: Fri, 08 Nov 2013 08:18:35 +0500
>>>> From: Omair Javaid <omair.javaid@linaro.org>
>>>> CC: gdb-patches@sourceware.org, Patch Tracking <patches@linaro.org>
>>>>
>>>> --- gdb/NEWS  11 Oct 2013 13:51:26 -0000      1.622
>>>> +++ gdb/NEWS  7 Nov 2013 23:58:26 -0000
>>>> @@ -3,6 +3,10 @@
>>>
>>> This part is OK, but please make sure to have 2 spaces between
>>> sentences
>>>
>>>> +* Improved support of process record-replay and reverse debugging on
>>>> +  arm*-linux* targets. Support for thumb32 and syscall instructions
>>>                          ^^
>>> here.
>>>
>>> Thanks.
>>
>
> Hello Oza,
>
> I really appreciate your work on arm process record and I am trying to 
> improve on the work you have done previously. I have sent 3 patches 
> upstream which include basic support for Thumb32 instructions and 
> system call instructions along with some fixes.
>
> There were around 1500 failures in gdb.reverse on arm that have been 
> significantly reduced. Here is a current status of gdb.reverse test 
> suite on arm targets:
>
> arm-native configuration:
> # of expected passes		2253
> # of unexpected failures	71
>
> arm-remote configuration:
> # of expected passes		2142
> # of unexpected failures	122
>
> I am currently working on patches to fix above unexpected failures and 
> also working on supporting co-processor and other unsupported 
> instruction types.
>
> --
> Omair.

After incorporating all suggestions I am posting a final version of all 
three patches posted earlier. Looking for a go ahead for commit.

== PATCH 0 ==

This patch adds a news entry about improved process record-replay on
arm*-linux* targets.
It also adds linux-record.o to gdb_target_obs in configure.tgt and
enables gdb.reverse testsuite for arm*-linux* targets.

gdb:

2013-11-08  Omair Javaid  <omair.javaid@linaro.org>

	* NEWS: Add note on improved process record-replay on arm*-linux*
	targets.
	* configure.tgt: Add linux-record.o to gdb_target_obs.

gdb/testsuite:

2013-10-24  Omair Javaid  <omair.javaid@linaro.org>

	* lib/gdb.exp: Enable gdb.reverse testsuite for arm*-linux* targets.


---
 gdb/NEWS                  |    4 ++++
 gdb/configure.tgt         |    2 +-
 gdb/testsuite/lib/gdb.exp |    6 ++++--
 3 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/gdb/NEWS b/gdb/NEWS
index 10834df..bcf3e09 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -3,6 +3,10 @@
 
 *** Changes since GDB 7.6
 
+* Improved support of process record-replay and reverse debugging on
+  arm*-linux* targets.  Support for thumb32 and syscall instructions
+  recording has been added.
+
 * GDB now supports Fission DWP file format version 2.
   http://gcc.gnu.org/wiki/DebugFission
 
diff --git a/gdb/configure.tgt b/gdb/configure.tgt
index ea0faf1..5410f72 100644
--- a/gdb/configure.tgt
+++ b/gdb/configure.tgt
@@ -89,7 +89,7 @@ arm*-wince-pe | arm*-*-mingw32ce*)
 arm*-*-linux*)
 	# Target: ARM based machine running GNU/Linux
 	gdb_target_obs="arm-tdep.o arm-linux-tdep.o glibc-tdep.o \
-			solib-svr4.o symfile-mem.o linux-tdep.o"
+			solib-svr4.o symfile-mem.o linux-tdep.o linux-record.o"
 	build_gdbserver=yes
 	;;
 arm*-*-netbsd* | arm*-*-knetbsd*-gnu)
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index bde4e48..047aefb 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -1774,7 +1774,8 @@ proc supports_process_record {} {
 	return [target_info gdb,use_precord]
     }
 
-    if { [istarget "x86_64-*-linux*"] || [istarget "i\[34567\]86-*-linux*"] } {
+    if { [istarget "arm*-*-linux*"] || [istarget "x86_64-*-linux*"]
+         || [istarget "i\[34567\]86-*-linux*"] } {
 	return 1
     }
 
@@ -1789,7 +1790,8 @@ proc supports_reverse {} {
 	return [target_info gdb,can_reverse]
     }
 
-    if { [istarget "x86_64-*-linux*"] || [istarget "i\[34567\]86-*-linux*"] } {
+    if { [istarget "arm*-*-linux*"] || [istarget "x86_64-*-linux*"]
+         || [istarget "i\[34567\]86-*-linux*"] } {
 	return 1
     }
 
--