From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13166 invoked by alias); 20 Dec 2013 12:38:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13157 invoked by uid 89); 20 Dec 2013 12:38:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Dec 2013 12:38:55 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBKCcoC0032341 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 20 Dec 2013 07:38:50 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rBKCclr4026017; Fri, 20 Dec 2013 07:38:48 -0500 Message-ID: <52B43A57.7050705@redhat.com> Date: Fri, 20 Dec 2013 12:38:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Omair Javaid CC: oza Pawandeep , Yao Qi , "gdb-patches@sourceware.org" , patches , Eli Zaretskii Subject: Re: [PATCH 0/2] GDB process record and reverse debugging improvements for arm*-linux* References: <52687B1A.2050003@codesourcery.com> <527C580B.5020100@linaro.org> <83k3gj5p9t.fsf@gnu.org> <52809426.40405@linaro.org> <52929058.1050202@linaro.org> In-Reply-To: <52929058.1050202@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-12/txt/msg00827.txt.bz2 On 11/24/2013 11:48 PM, Omair Javaid wrote: > After incorporating all suggestions I am posting a final version of all > three patches posted earlier. Looking for a go ahead for commit. All three emails in the series have the same subject apart from the numbers, which make it confusing. It'd be good if you made sure the subjects were actually different, and more specific, in the git commit log. Hmm, I'm also surprised to now find that this "0/2" email actually contains a patch. That makes it actually 3 patches in the series. This is not the standard de facto way to send a series. The best way is for 0 to be the series intro, with no patch, and then have the patches be replies to the intro mail. (I'd suggest addressing the comments I just sent to patches #1 and #2, and resend the whole series with git send-mail, which does that for you automatically.) > > == PATCH 0 == > > This patch adds a news entry about improved process record-replay on > arm*-linux* targets. > It also adds linux-record.o to gdb_target_obs in configure.tgt and > enables gdb.reverse testsuite for arm*-linux* targets. These could be two separate patches, with NEWS actually being the last patch in the whole series. > gdb/testsuite: > > 2013-10-24 Omair Javaid > > * lib/gdb.exp: Enable gdb.reverse testsuite for arm*-linux* targets. Write: * lib/gdb.exp (supports_process_record): Return true for arm*-linux*. Otherwise looks good. -- Pedro Alves