From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Delegate to target_ops->beneath to read cache lines
Date: Fri, 29 Nov 2013 13:47:00 -0000 [thread overview]
Message-ID: <529883D7.3030606@redhat.com> (raw)
In-Reply-To: <52980180.1050000@codesourcery.com>
Patch is OK, thanks.
A comment on the commit log:
On 11/29/2013 02:52 AM, Yao Qi wrote:
>
> Note that using ¤t_target in dcache_read_line will cause an
> endless recursion, so I change it to current_target.beneath.
Hmm, that's not what I recall and documented in
target_read_memory, etc.
/* Dispatch to the topmost target, not the flattened current_target.
Memory accesses check target->to_has_(all_)memory, and the
flattened target doesn't inherit those. */
And indeed, if I tweak the patch to drop that hunk,
that's still what I see. What recursion did you see?
--
Pedro Alves
next prev parent reply other threads:[~2013-11-29 12:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 12:41 Yao Qi
2013-11-27 15:27 ` Pedro Alves
2013-11-29 11:12 ` Yao Qi
2013-11-29 13:47 ` Pedro Alves [this message]
2013-11-29 14:00 ` Yao Qi
2013-11-29 14:27 ` Pedro Alves
2013-11-29 20:06 ` Doug Evans
2013-11-29 20:16 ` Pedro Alves
2013-12-02 6:07 ` Yao Qi
2013-12-02 10:36 ` Pedro Alves
2013-12-02 11:04 ` Yao Qi
2013-12-02 11:12 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529883D7.3030606@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox