From: Pedro Alves <palves@redhat.com>
To: Doug Evans <xdje42@gmail.com>
Cc: Yao Qi <yao@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Delegate to target_ops->beneath to read cache lines
Date: Fri, 29 Nov 2013 20:16:00 -0000 [thread overview]
Message-ID: <5298F22F.8090008@redhat.com> (raw)
In-Reply-To: <CAP9bCMTpcUJ_Okp8XwBhCQefsKrfkUo4iKcrv8B_Xip4Hc+h8w@mail.gmail.com>
On 11/29/2013 07:42 PM, Doug Evans wrote:
> I think a comment is required here explaining why things are the way they are.
> i.e., why we use current_target.beneath instead of ¤t_target.
I suggest adding a target_read_raw_memory function, similar,
and next to target_read_memory, target_read_stack, etc., and
put the comment there. Incidentally, I notice target_read_code
misses the comment.
--
Pedro Alves
next prev parent reply other threads:[~2013-11-29 19:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 12:41 Yao Qi
2013-11-27 15:27 ` Pedro Alves
2013-11-29 11:12 ` Yao Qi
2013-11-29 13:47 ` Pedro Alves
2013-11-29 14:00 ` Yao Qi
2013-11-29 14:27 ` Pedro Alves
2013-11-29 20:06 ` Doug Evans
2013-11-29 20:16 ` Pedro Alves [this message]
2013-12-02 6:07 ` Yao Qi
2013-12-02 10:36 ` Pedro Alves
2013-12-02 11:04 ` Yao Qi
2013-12-02 11:12 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5298F22F.8090008@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=xdje42@gmail.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox