Re: [PATCH] Delegate to target_ops->beneath to read cache lines

Pedro Alves
2013-11-29T12:09:08Z

Patch is OK, thanks.

A comment on the commit log:

On 11/29/2013 02:52 AM, Yao Qi wrote:
>
> Note that using &current_target in dcache_read_line will cause an
> endless recursion, so I change it to current_target.beneath.

Hmm, that's not what I recall and documented in
target_read_memory, etc.

/* Dispatch to the topmost target, not the flattened current_target.
Memory accesses check target->to_has_(all_)memory, and the
flattened target doesn't inherit those. */

And indeed, if I tweak the patch to drop that hunk,
that's still what I see. What recursion did you see?

--
Pedro Alves