From: Hui Zhu <hui_zhu@mentor.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Cc: Pedro Alves <palves@redhat.com>,
gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Let gdbserver doesn't tell GDB it support target-side breakpoint conditions and commands if it doesn't support 'Z' packet
Date: Fri, 29 Nov 2013 09:41:00 -0000 [thread overview]
Message-ID: <5297EA73.50201@mentor.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1311281550130.21686@tp.orcam.me.uk>
On 11/29/13 00:18, Maciej W. Rozycki wrote:
> On Thu, 28 Nov 2013, Hui Zhu wrote:
>
>> According to your comments. I make a new patch for it.
>> It add a check in remote_insert_breakpoint. If this breakpoint have target
>> breakpoint but it is not handled by "Z" packet, function will return error.
>>
>> Please help me review it.
>>
>> Because mi-dprintf.exp and dprintf.exp use "set dprintf-style agent" check if
>> target support target-side breakpoint, they are still got fail after this
>> patch.
>> If you think this patch's idea is OK, I will make patch for them.
>>
>> Thanks,
>> Hui
>>
>> 2013-11-28 Hui Zhu <hui@codesourcery.com>
>>
>> * remote.c (remote_insert_breakpoint): Add
>> have_target_target_side_commands.
>
> Please note that this is PR gdb/16101 now and refer to it in the
> ChangeLog entry.
>
> Maciej
>
Hi Maciej,
Thanks for your remind.
Update changelog to:
2013-11-28 Hui Zhu <hui@codesourcery.com>
PR gdb/16101
* remote.c (remote_insert_breakpoint): Add
have_target_target_side_commands.
Thanks,
Hui
next prev parent reply other threads:[~2013-11-29 1:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 10:30 Hui Zhu
2013-10-21 15:37 ` Pedro Alves
2013-11-28 10:56 ` Hui Zhu
2013-11-28 17:38 ` Maciej W. Rozycki
2013-11-29 9:41 ` Hui Zhu [this message]
2013-11-29 15:27 ` [pushed] Plug target side conditions and commands leaks (was: Re: [PATCH] Let gdbserver doesn't tell GDB it support target-side breakpoint conditions and commands if it doesn't support 'Z' packet) Pedro Alves
2013-11-29 16:05 ` [PATCH] Let gdbserver doesn't tell GDB it support target-side breakpoint conditions and commands if it doesn't support 'Z' packet Pedro Alves
2013-12-02 12:45 ` Hui Zhu
2013-12-02 14:38 ` Pedro Alves
2013-12-03 4:50 ` Hui Zhu
2013-12-03 4:54 ` Hui Zhu
2013-12-06 19:29 ` Pedro Alves
2013-12-08 5:19 ` Hui Zhu
2013-12-08 8:34 ` Doug Evans
2013-12-08 14:18 ` Hui Zhu
2013-12-09 19:48 ` Pedro Alves
2013-12-09 21:07 ` Doug Evans
2013-12-10 17:34 ` Pedro Alves
2013-12-10 18:14 ` [PATCH] Eliminate UNSUPPORTED_ERROR Pedro Alves
2013-12-11 16:33 ` Doug Evans
2013-12-11 19:17 ` Pedro Alves
2013-12-12 4:23 ` Doug Evans
2013-12-12 10:23 ` Pedro Alves
2013-12-11 16:40 ` [PATCH] Let gdbserver doesn't tell GDB it support target-side breakpoint conditions and commands if it doesn't support 'Z' packet Doug Evans
2013-12-12 10:55 ` breakpoint.c:insert_bp_location: Constify local. (was: Re: [PATCH] Let gdbserver doesn't tell GDB it support target-side breakpoint conditions and commands if it doesn't support 'Z' packet) Pedro Alves
2013-12-12 12:55 ` [PATCH] Let gdbserver doesn't tell GDB it support target-side breakpoint conditions and commands if it doesn't support 'Z' packet Pedro Alves
2014-01-09 18:36 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5297EA73.50201@mentor.com \
--to=hui_zhu@mentor.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@codesourcery.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox