From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20441 invoked by alias); 29 Nov 2013 01:14:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20426 invoked by uid 89); 29 Nov 2013 01:14:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_40,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from Unknown (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 29 Nov 2013 01:14:45 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1VmCf8-0005kY-2o from Hui_Zhu@mentor.com ; Thu, 28 Nov 2013 17:14:30 -0800 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 28 Nov 2013 17:14:30 -0800 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.2.247.3; Thu, 28 Nov 2013 17:13:38 -0800 Message-ID: <5297EA73.50201@mentor.com> Date: Fri, 29 Nov 2013 09:41:00 -0000 From: Hui Zhu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: "Maciej W. Rozycki" CC: Pedro Alves , gdb-patches ml Subject: Re: [PATCH] Let gdbserver doesn't tell GDB it support target-side breakpoint conditions and commands if it doesn't support 'Z' packet References: <5265022F.8060203@mentor.com> <52654A2C.9010202@redhat.com> <529707C7.4040504@mentor.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00897.txt.bz2 On 11/29/13 00:18, Maciej W. Rozycki wrote: > On Thu, 28 Nov 2013, Hui Zhu wrote: > >> According to your comments. I make a new patch for it. >> It add a check in remote_insert_breakpoint. If this breakpoint have target >> breakpoint but it is not handled by "Z" packet, function will return error. >> >> Please help me review it. >> >> Because mi-dprintf.exp and dprintf.exp use "set dprintf-style agent" check if >> target support target-side breakpoint, they are still got fail after this >> patch. >> If you think this patch's idea is OK, I will make patch for them. >> >> Thanks, >> Hui >> >> 2013-11-28 Hui Zhu >> >> * remote.c (remote_insert_breakpoint): Add >> have_target_target_side_commands. > > Please note that this is PR gdb/16101 now and refer to it in the > ChangeLog entry. > > Maciej > Hi Maciej, Thanks for your remind. Update changelog to: 2013-11-28 Hui Zhu PR gdb/16101 * remote.c (remote_insert_breakpoint): Add have_target_target_side_commands. Thanks, Hui