Re: [PATCH] Eliminate UNSUPPORTED_ERROR.

[Doug Evans <xdje42@gmail.com>]

On Wed, Dec 11, 2013 at 11:17 AM, Pedro Alves <palves@redhat.com> wrote:
> On 12/11/2013 04:33 PM, Doug Evans wrote:
>>> > -         /* Should we fallback to ye olde GDB script mode?  */
>>> > -         if (script_ext_mode == script_ext_soft
>>> > -             && e.reason == RETURN_ERROR && e.error == UNSUPPORTED_ERROR)
>>> > -           {
>>> > -             fseek (stream, 0, SEEK_SET);
>>> > -             script_from_file (stream, (char*) file);
>>> > -           }
>>> > -         else
>>> > -           {
>>> > -             /* Nope, just punt.  */
>>> > -             throw_exception (e);
>>> > -           }
>>> > +         /* Fallback to GDB script mode.  */
>>> > +         fseek (stream, 0, SEEK_SET);
>>> > +         script_from_file (stream, (char*) file);
>> Remove the fseek and cast.
>
> Hmm, indeed the fseek doesn't look necessary.  Will do.  However,
> that makes me wonder whether I'm missing something, as it doesn't
> look necessary before my patch either.  Was it ever really
> needed?

I think I added it to be extra conservative in case
source_python_script happened to read from the file.
[I know it normally wouldn't read and then throw an UNSUPPORTED_ERROR,
but I'm guessing I didn't want this code to assume that.]

Now that we're not even calling source_python_script the need is gone.

 I see you added it (and the unnecessary cast too ;-) ) in:
>   https://www.sourceware.org/ml/gdb-patches/2010-04/msg00110.html
> but I can't tell why.

script_from_file was changed to take a const char *arg the prior week.
Presumably I just didn't update that part of the patch.