From: Pedro Alves <palves@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Fix DW_OP_GNU_regval_type with FP registers
Date: Fri, 15 Nov 2013 14:54:00 -0000 [thread overview]
Message-ID: <5286326C.8010204@redhat.com> (raw)
In-Reply-To: <20131115120635.GV3481@adacore.com>
On 11/15/2013 12:06 PM, Joel Brobecker wrote:
>
> Regarding Pedro's suggestion, what do we think of "read_addr_from_reg"?
> Still not perfect, as it hides a bit the fact that it only does
> a partial register read if the address size is smaller than the
> register size. But much better than "read_reg", I agree.
That sounds fine to me. It maps well to address_from_register.
--
Pedro Alves
next prev parent reply other threads:[~2013-11-15 14:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 15:21 Joel Brobecker
2013-11-14 20:12 ` Pedro Alves
2013-11-14 21:02 ` Tom Tromey
2013-11-15 12:19 ` Joel Brobecker
2013-11-15 14:54 ` Pedro Alves [this message]
2013-11-16 5:46 ` [RFA] Rename "read_reg" into "read_addr_from_reg" in struct dwarf_expr_context_funcs Joel Brobecker
2013-11-17 3:02 ` Pedro Alves
2013-11-17 9:43 ` pushed: " Joel Brobecker
2013-11-18 12:39 ` [OB] Simplify dwarf2-frame.c:read_addr_from_reg. (was: [RFA] Rename "read_reg" into "read_addr_from_reg" in struct dwarf_expr_context_funcs) Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5286326C.8010204@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox