From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Fix DW_OP_GNU_regval_type with FP registers
Date: Thu, 14 Nov 2013 21:02:00 -0000 [thread overview]
Message-ID: <877gcawvp9.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1384434175-15561-1-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Thu, 14 Nov 2013 08:02:55 -0500")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> * dwarf2expr.h (struct dwarf_expr_context_funcs) <read_reg>:
Joel> Extend the documentation a bit.
Joel> <get_reg_value>: New field.
Joel> * dwarf2loc.c (dwarf_expr_get_reg_value)
Joel> (needs_frame_get_reg_value): New functions.
Joel> (dwarf_expr_ctx_funcs, needs_frame_ctx_funcs): Add "get_reg_value"
Joel> callback.
Joel> * dwarf2-frame.c (get_reg_value): New function.
Joel> (dwarf2_frame_ctx_funcs): Add "get_reg_value" callback.
Joel> * dwarf2expr.c (execute_stack_op) <DW_OP_GNU_regval_type>:
Joel> Use new callback to compute result_val.
Joel> gdb/testsuite/ChangeLog:
Joel> * O2_float_param: New testcase.
Joel> tested on x86_64-linux and ppc-linux.
Joel> OK to commit?
It looks good to me.
Tom
next prev parent reply other threads:[~2013-11-14 20:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 15:21 Joel Brobecker
2013-11-14 20:12 ` Pedro Alves
2013-11-14 21:02 ` Tom Tromey [this message]
2013-11-15 12:19 ` Joel Brobecker
2013-11-15 14:54 ` Pedro Alves
2013-11-16 5:46 ` [RFA] Rename "read_reg" into "read_addr_from_reg" in struct dwarf_expr_context_funcs Joel Brobecker
2013-11-17 3:02 ` Pedro Alves
2013-11-17 9:43 ` pushed: " Joel Brobecker
2013-11-18 12:39 ` [OB] Simplify dwarf2-frame.c:read_addr_from_reg. (was: [RFA] Rename "read_reg" into "read_addr_from_reg" in struct dwarf_expr_context_funcs) Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gcawvp9.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox