From: Pedro Alves <palves@redhat.com>
To: Doug Evans <xdje42@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] simplify bpstat_check_breakpoint_conditions
Date: Tue, 12 Nov 2013 09:54:00 -0000 [thread overview]
Message-ID: <5281F6DB.2010603@redhat.com> (raw)
In-Reply-To: <m3zjpap8m1.fsf@seba.sebabeach.org>
On 11/12/2013 04:05 AM, Doug Evans wrote:
> This patch simplifies bpstat_check_breakpoint_conditions a bit.
>
> Regression tested on amd64-linux.
> Ok to check in?
Looks good to me.
> [Appended at the end is the same patch with diff's -b option added
> to make the actual changes easier to see.]
Thanks, that's quite helpful.
>
> 2013-11-11 Doug Evans <xdje42@gmail.com>
>
> * breakpoint.c (bpstat_check_breakpoint_conditions): Assert
> bs->stop != 0 on entry. Update function comment. Simplify early
> exit for frame mismatch. Reindent rest of function.
--
Pedro Alves
next prev parent reply other threads:[~2013-11-12 9:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 7:58 Doug Evans
2013-11-12 9:54 ` Pedro Alves [this message]
2013-11-13 3:03 ` [PATCH] Don't evaluate condition for non-matching thread Doug Evans
2013-11-13 9:59 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5281F6DB.2010603@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox