From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5287 invoked by alias); 12 Nov 2013 09:37:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5276 invoked by uid 89); 12 Nov 2013 09:37:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Nov 2013 09:37:41 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAC9bXIR021703 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 12 Nov 2013 04:37:33 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rAC9bW8l032714; Tue, 12 Nov 2013 04:37:32 -0500 Message-ID: <5281F6DB.2010603@redhat.com> Date: Tue, 12 Nov 2013 09:54:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Doug Evans CC: gdb-patches@sourceware.org Subject: Re: [PATCH] simplify bpstat_check_breakpoint_conditions References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-11/txt/msg00310.txt.bz2 On 11/12/2013 04:05 AM, Doug Evans wrote: > This patch simplifies bpstat_check_breakpoint_conditions a bit. > > Regression tested on amd64-linux. > Ok to check in? Looks good to me. > [Appended at the end is the same patch with diff's -b option added > to make the actual changes easier to see.] Thanks, that's quite helpful. > > 2013-11-11 Doug Evans > > * breakpoint.c (bpstat_check_breakpoint_conditions): Assert > bs->stop != 0 on entry. Update function comment. Simplify early > exit for frame mismatch. Reindent rest of function. -- Pedro Alves