From: Pedro Alves <palves@redhat.com>
To: Doug Evans <xdje42@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Don't evaluate condition for non-matching thread
Date: Wed, 13 Nov 2013 09:59:00 -0000 [thread overview]
Message-ID: <52834D28.6020506@redhat.com> (raw)
In-Reply-To: <m3vbzxovhm.fsf_-_@seba.sebabeach.org>
On 11/13/2013 03:01 AM, Doug Evans wrote:
> Is there a reason the current code is the way it is?
I can't think of any. I'm actually surprised we do this.
We'd get the same effect if/when we push the thread check
down to the target, and I wouldn't imagine this "always eval
condition first" blocking such new feature.
> [I realize conditions can have side-effects, to, e.g., collect data,
> but the user has made the breakpoint thread-specific already.]
Yeah. There are several other ways to get to same result, so
it's not a real issue, IMO.
> If you think this warrants a NEWS entry I can certainly add one.
I don't think so.
> Ok to check in?
OK.
Thanks,
--
Pedro Alves
prev parent reply other threads:[~2013-11-13 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 7:58 [PATCH] simplify bpstat_check_breakpoint_conditions Doug Evans
2013-11-12 9:54 ` Pedro Alves
2013-11-13 3:03 ` [PATCH] Don't evaluate condition for non-matching thread Doug Evans
2013-11-13 9:59 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52834D28.6020506@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox