From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: Re: [RFC 0/7] Move language-related stuff out of varobj.c
Date: Sat, 28 Sep 2013 00:56:00 -0000 [thread overview]
Message-ID: <52462919.7030100@codesourcery.com> (raw)
In-Reply-To: <1379512482-31773-1-git-send-email-yao@codesourcery.com>
On 09/18/2013 09:54 PM, Yao Qi wrote:
> This patch series is to move language-related stuff out of varobj.c
> to ada-varobj.c, c-varobj.c and jv-varobj.c. This will shorten
> varobj.c, and make it easier for varobj support for new languages.
>
> Nowadays, we have 'struct language_specific' which is about language
> operations in varobj. This can be moved out of varobj.c and shared
> for different languages. This is what patch 5/7 does. Operations
> of each language need to know 'struct varobj', so 'struct varobj'
> should be moved to varobj.h. This is what patch 4/7 does. Note
> that we don't move all 'struct varobj' to varobj.h because some fields
> are related to dynamic varobj, and make no sense to expose them.
> I move basic part of 'struct varobj' to varobj.h, and define a new
> struct varobj_dynamic to extend 'struct varobj'.
>
> Then, we can move language related operations out of varobj.c to
> c-varobj.c, ada-varobj.c and jv-varobj.c respectively. This is
> done by patch 6/7.
>
> Patch 1/7 - 3/7 are cleanups, to remove unused bits in varobj.c.
> Patch 7/7 is a cleanup too.
>
> Note that static array 'languages' is still used in varobj.c, which
> is not really necessary. We can remove it and move each
> 'struct lang_varobj_ops *' to be a field of 'struct language_defn'.
> I don't include this change in this series because I'd like to post
> patches for review before I go too far away.
>
> The whole series is tested on x86_64-linux. Comments?
Ping. https://sourceware.org/ml/gdb-patches/2013-09/msg00591.html
--
Yao (é½å°§)
prev parent reply other threads:[~2013-09-28 0:56 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 13:55 Yao Qi
2013-09-18 13:55 ` [PATCH 2/7] Remove vlang_unknown Yao Qi
2013-10-01 10:07 ` Joel Brobecker
2013-10-01 13:34 ` Yao Qi
2013-10-02 0:19 ` Doug Evans
2013-10-02 9:32 ` Joel Brobecker
2013-10-04 8:31 ` Yao Qi
2013-09-18 13:55 ` [PATCH 3/7] Remove field value_of_root Yao Qi
2013-10-01 10:16 ` Joel Brobecker
2013-10-01 13:52 ` Yao Qi
2013-09-18 13:55 ` [PATCH 7/7] Remove ada-varobj.h Yao Qi
2013-10-17 5:46 ` Joel Brobecker
2013-10-17 13:34 ` Yao Qi
2013-09-18 13:55 ` [PATCH 1/7] Remove field language in struct language_specific Yao Qi
2013-10-01 10:03 ` Joel Brobecker
2013-10-01 13:35 ` Yao Qi
2013-09-18 13:55 ` [PATCH 4/7] Move struct varobj to varobj.h Yao Qi
2013-10-02 9:46 ` Joel Brobecker
2013-10-02 19:32 ` Doug Evans
2013-10-06 6:33 ` Yao Qi
2013-10-08 4:56 ` Joel Brobecker
2013-10-08 21:03 ` Doug Evans
2013-10-09 0:28 ` Yao Qi
2013-10-14 8:19 ` Yao Qi
2013-09-18 13:55 ` [PATCH 6/7] Move language stuff out of varobj.c Yao Qi
2013-10-11 8:20 ` Yao Qi
2013-10-17 5:40 ` Joel Brobecker
2013-10-17 13:33 ` Yao Qi
2013-09-18 13:55 ` [PATCH 5/7] New lang-varobj.h Yao Qi
2013-10-02 17:18 ` Doug Evans
2013-10-08 4:59 ` Joel Brobecker
2013-10-09 23:51 ` Yao Qi
2013-10-09 23:56 ` Doug Evans
2013-10-10 0:19 ` Yao Qi
2013-09-28 0:56 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52462919.7030100@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox