From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6529 invoked by alias); 28 Sep 2013 00:56:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6519 invoked by uid 89); 28 Sep 2013 00:56:24 -0000 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 28 Sep 2013 00:56:24 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.5 required=5.0 tests=AWL,BAYES_00,GARBLED_BODY,RDNS_NONE,SPF_HELO_FAIL autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1VPipX-0006eG-CE from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Fri, 27 Sep 2013 17:56:19 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Fri, 27 Sep 2013 17:56:19 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Fri, 27 Sep 2013 17:56:19 -0700 Message-ID: <52462919.7030100@codesourcery.com> Date: Sat, 28 Sep 2013 00:56:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Subject: Re: [RFC 0/7] Move language-related stuff out of varobj.c References: <1379512482-31773-1-git-send-email-yao@codesourcery.com> In-Reply-To: <1379512482-31773-1-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00985.txt.bz2 On 09/18/2013 09:54 PM, Yao Qi wrote: > This patch series is to move language-related stuff out of varobj.c > to ada-varobj.c, c-varobj.c and jv-varobj.c. This will shorten > varobj.c, and make it easier for varobj support for new languages. > > Nowadays, we have 'struct language_specific' which is about language > operations in varobj. This can be moved out of varobj.c and shared > for different languages. This is what patch 5/7 does. Operations > of each language need to know 'struct varobj', so 'struct varobj' > should be moved to varobj.h. This is what patch 4/7 does. Note > that we don't move all 'struct varobj' to varobj.h because some fields > are related to dynamic varobj, and make no sense to expose them. > I move basic part of 'struct varobj' to varobj.h, and define a new > struct varobj_dynamic to extend 'struct varobj'. > > Then, we can move language related operations out of varobj.c to > c-varobj.c, ada-varobj.c and jv-varobj.c respectively. This is > done by patch 6/7. > > Patch 1/7 - 3/7 are cleanups, to remove unused bits in varobj.c. > Patch 7/7 is a cleanup too. > > Note that static array 'languages' is still used in varobj.c, which > is not really necessary. We can remove it and move each > 'struct lang_varobj_ops *' to be a field of 'struct language_defn'. > I don't include this change in this series because I'd like to post > patches for review before I go too far away. > > The whole series is tested on x86_64-linux. Comments? Ping. https://sourceware.org/ml/gdb-patches/2013-09/msg00591.html -- Yao (齐尧)