From: Joel Brobecker <brobecker@adacore.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 7/7] Remove ada-varobj.h.
Date: Thu, 17 Oct 2013 05:46:00 -0000 [thread overview]
Message-ID: <20131017054642.GB3302@adacore.com> (raw)
In-Reply-To: <1379512482-31773-8-git-send-email-yao@codesourcery.com>
> As a result of previous patch, extern functions in ada-varobj.c can be
> made static, and ada-varobj.h can be removed too.
>
> gdb:
>
> 2013-09-18 Yao Qi <yao@codesourcery.com>
>
> * Makefile.in (HFILES_NO_SRCDIR): Remove ada-varobj.h.
> * ada-varobj.c: Remove the include of ada-varobj.h.
> (ada_varobj_get_number_of_children): Declare.
> (ada_varobj_get_name_of_child): Make it static.
> (ada_varobj_get_path_expr_of_child): Likewise.
> (ada_varobj_get_value_of_child): Likewise.
> (ada_varobj_get_type_of_child): Likewise.
> (ada_varobj_get_value_of_array_variable): Likewise.
> * ada-varobj.h: Remove.
Thank you. OK to commit with one minor nit:
> @@ -57,6 +56,9 @@
>
> The results are written in place. */
>
> +static int ada_varobj_get_number_of_children (struct value *parent_value,
> + struct type *parent_type);
> +
> static void
> ada_varobj_decode_var (struct value **value_ptr, struct type **type_ptr)
> {
That declaration needs to be inserted _before_ the comment describing
ada_varobj_decode_var.
--
Joel
next prev parent reply other threads:[~2013-10-17 5:46 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 13:55 [RFC 0/7] Move language-related stuff out of varobj.c Yao Qi
2013-09-18 13:55 ` [PATCH 4/7] Move struct varobj to varobj.h Yao Qi
2013-10-02 9:46 ` Joel Brobecker
2013-10-02 19:32 ` Doug Evans
2013-10-06 6:33 ` Yao Qi
2013-10-08 4:56 ` Joel Brobecker
2013-10-08 21:03 ` Doug Evans
2013-10-09 0:28 ` Yao Qi
2013-10-14 8:19 ` Yao Qi
2013-09-18 13:55 ` [PATCH 6/7] Move language stuff out of varobj.c Yao Qi
2013-10-11 8:20 ` Yao Qi
2013-10-17 5:40 ` Joel Brobecker
2013-10-17 13:33 ` Yao Qi
2013-09-18 13:55 ` [PATCH 5/7] New lang-varobj.h Yao Qi
2013-10-02 17:18 ` Doug Evans
2013-10-08 4:59 ` Joel Brobecker
2013-10-09 23:51 ` Yao Qi
2013-10-09 23:56 ` Doug Evans
2013-10-10 0:19 ` Yao Qi
2013-09-18 13:55 ` [PATCH 7/7] Remove ada-varobj.h Yao Qi
2013-10-17 5:46 ` Joel Brobecker [this message]
2013-10-17 13:34 ` Yao Qi
2013-09-18 13:55 ` [PATCH 3/7] Remove field value_of_root Yao Qi
2013-10-01 10:16 ` Joel Brobecker
2013-10-01 13:52 ` Yao Qi
2013-09-18 13:55 ` [PATCH 2/7] Remove vlang_unknown Yao Qi
2013-10-01 10:07 ` Joel Brobecker
2013-10-01 13:34 ` Yao Qi
2013-10-02 0:19 ` Doug Evans
2013-10-02 9:32 ` Joel Brobecker
2013-10-04 8:31 ` Yao Qi
2013-09-18 13:55 ` [PATCH 1/7] Remove field language in struct language_specific Yao Qi
2013-10-01 10:03 ` Joel Brobecker
2013-10-01 13:35 ` Yao Qi
2013-09-28 0:56 ` [RFC 0/7] Move language-related stuff out of varobj.c Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131017054642.GB3302@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox