From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7993 invoked by alias); 17 Oct 2013 05:46:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7982 invoked by uid 89); 17 Oct 2013 05:46:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 17 Oct 2013 05:46:48 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 7031B116541; Thu, 17 Oct 2013 01:47:09 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id WiA4uel3BOwT; Thu, 17 Oct 2013 01:47:09 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 1064A1164FF; Thu, 17 Oct 2013 01:47:09 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 81834E10A0; Thu, 17 Oct 2013 09:46:42 +0400 (RET) Date: Thu, 17 Oct 2013 05:46:00 -0000 From: Joel Brobecker To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 7/7] Remove ada-varobj.h. Message-ID: <20131017054642.GB3302@adacore.com> References: <1379512482-31773-1-git-send-email-yao@codesourcery.com> <1379512482-31773-8-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1379512482-31773-8-git-send-email-yao@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-10/txt/msg00507.txt.bz2 > As a result of previous patch, extern functions in ada-varobj.c can be > made static, and ada-varobj.h can be removed too. > > gdb: > > 2013-09-18 Yao Qi > > * Makefile.in (HFILES_NO_SRCDIR): Remove ada-varobj.h. > * ada-varobj.c: Remove the include of ada-varobj.h. > (ada_varobj_get_number_of_children): Declare. > (ada_varobj_get_name_of_child): Make it static. > (ada_varobj_get_path_expr_of_child): Likewise. > (ada_varobj_get_value_of_child): Likewise. > (ada_varobj_get_type_of_child): Likewise. > (ada_varobj_get_value_of_array_variable): Likewise. > * ada-varobj.h: Remove. Thank you. OK to commit with one minor nit: > @@ -57,6 +56,9 @@ > > The results are written in place. */ > > +static int ada_varobj_get_number_of_children (struct value *parent_value, > + struct type *parent_type); > + > static void > ada_varobj_decode_var (struct value **value_ptr, struct type **type_ptr) > { That declaration needs to be inserted _before_ the comment describing ada_varobj_decode_var. -- Joel