From: Pedro Alves <palves@redhat.com>
To: lgustavo@codesourcery.com
Cc: Yao Qi <yao@codesourcery.com>,
"'gdb-patches@sourceware.org'"
<gdb-patches@sourceware.org>,
Mike Frysinger <vapier@gentoo.org>
Subject: Re: [PATCH, gdbserver] Further cleanup of FDPIC/DSBT divergences
Date: Mon, 12 Aug 2013 14:06:00 -0000 [thread overview]
Message-ID: <5208EBDD.4030504@redhat.com> (raw)
In-Reply-To: <5208E601.6070000@codesourcery.com>
On 08/12/2013 02:41 PM, Luis Machado wrote:
>>> +
>>> + /* Fetch the DSBT_INDEX from the shared library file on disk. */
>>> + if (scan_dyntag_in_bfd (DT_TIC6X_DSBT_INDEX, solib_bfd, &addr) == 0)
>>
>> I don't find the definition of DT_TIC6X_DSBT_INDEX. In uclibc, I only
>> find DT_C6000_DSBT_INDEX.
>>
>
> That is exactly what it is. I named it DT_TIC6X_DSBT_INDEX to make it
> more meaningful, but i can use DT_C6000_DSBT_INDEX without problems i think.
Indeed. The kernel (arch/c6x/include/asm/elf.h) has:
85 /* C6X specific DT_ tags */
86 #define DT_C6000_DSBT_BASE 0x70000000
87 #define DT_C6000_DSBT_SIZE 0x70000001
88 #define DT_C6000_PREEMPTMAP 0x70000002
89 #define DT_C6000_DSBT_INDEX 0x70000003
BFD also already has (include/elf/tic6x.h):
/* The hard-coded DSBT index for this module, if any. */
#define DT_C6000_DSBT_INDEX 0x70000003
IMO, yes, better stick with existing practice and not
invent new symbols.
--
Pedro Alves
next prev parent reply other threads:[~2013-08-12 14:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 18:57 Luis Machado
2013-06-24 13:47 ` Yao Qi
2013-06-24 14:25 ` Luis Machado
2013-08-08 16:41 ` Luis Machado
2013-08-09 15:08 ` Pedro Alves
2013-08-09 17:20 ` Luis Machado
2013-08-10 0:33 ` Yao Qi
2013-08-12 13:41 ` Luis Machado
2013-08-12 14:06 ` Pedro Alves [this message]
2013-08-26 5:31 ` Mike Frysinger
2013-06-24 16:17 ` Mike Frysinger
2013-06-25 15:03 ` Pedro Alves
2013-06-25 15:04 ` Luis Machado
2013-06-25 16:26 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5208EBDD.4030504@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=lgustavo@codesourcery.com \
--cc=vapier@gentoo.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox