From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30838 invoked by alias); 12 Aug 2013 14:06:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30829 invoked by uid 89); 12 Aug 2013 14:06:28 -0000 X-Spam-SWARE-Status: No, score=-8.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 12 Aug 2013 14:06:27 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7CE6NeH023222 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 12 Aug 2013 10:06:24 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7CE6MuK014995; Mon, 12 Aug 2013 10:06:22 -0400 Message-ID: <5208EBDD.4030504@redhat.com> Date: Mon, 12 Aug 2013 14:06:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: lgustavo@codesourcery.com CC: Yao Qi , "'gdb-patches@sourceware.org'" , Mike Frysinger Subject: Re: [PATCH, gdbserver] Further cleanup of FDPIC/DSBT divergences References: <51C34F14.8070803@codesourcery.com> <51C84CBD.10506@codesourcery.com> <51C84DD4.4090001@codesourcery.com> <5203CA36.5000206@codesourcery.com> <520505D9.8080103@redhat.com> <520524D8.40408@codesourcery.com> <52058A17.2050101@codesourcery.com> <5208E601.6070000@codesourcery.com> In-Reply-To: <5208E601.6070000@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00318.txt.bz2 On 08/12/2013 02:41 PM, Luis Machado wrote: >>> + >>> + /* Fetch the DSBT_INDEX from the shared library file on disk. */ >>> + if (scan_dyntag_in_bfd (DT_TIC6X_DSBT_INDEX, solib_bfd, &addr) == 0) >> >> I don't find the definition of DT_TIC6X_DSBT_INDEX. In uclibc, I only >> find DT_C6000_DSBT_INDEX. >> > > That is exactly what it is. I named it DT_TIC6X_DSBT_INDEX to make it > more meaningful, but i can use DT_C6000_DSBT_INDEX without problems i think. Indeed. The kernel (arch/c6x/include/asm/elf.h) has: 85 /* C6X specific DT_ tags */ 86 #define DT_C6000_DSBT_BASE 0x70000000 87 #define DT_C6000_DSBT_SIZE 0x70000001 88 #define DT_C6000_PREEMPTMAP 0x70000002 89 #define DT_C6000_DSBT_INDEX 0x70000003 BFD also already has (include/elf/tic6x.h): /* The hard-coded DSBT index for this module, if any. */ #define DT_C6000_DSBT_INDEX 0x70000003 IMO, yes, better stick with existing practice and not invent new symbols. -- Pedro Alves