* [commit] [OBV] Remove duplicate call to add_file_handler
@ 2013-08-02 10:31 Andrew Burgess
2013-08-02 11:12 ` Pedro Alves
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Burgess @ 2013-08-02 10:31 UTC (permalink / raw)
To: gdb-patches
Committed this patch to remove a duplicate call to add_file_handler,
the call to gdb_setup_readline will have performed the same call for
us.
I hope this ok to commit as obvious without review.
Thanks,
Andrew
2013-08-02 Andrew Burgess <aburgess@broadcom.com>
* mi/mi-interp.c (mi_interpreter_resume): Remove call to
add_file_handler.
diff -u -p -r1.84 mi-interp.c
--- ./gdb/mi/mi-interp.c 12 Mar 2013 18:50:39 -0000 1.84
+++ ./gdb/mi/mi-interp.c 2 Aug 2013 10:24:30 -0000
@@ -169,7 +169,6 @@ mi_interpreter_resume (void *data)
_intialize_event_loop. */
call_readline = gdb_readline2;
input_handler = mi_execute_command_input_handler;
- add_file_handler (input_fd, stdin_event_handler, 0);
async_command_editing_p = 0;
/* FIXME: This is a total hack for now. PB's use of the MI
implicitly relies on a bug in the async support which allows
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [commit] [OBV] Remove duplicate call to add_file_handler
2013-08-02 10:31 [commit] [OBV] Remove duplicate call to add_file_handler Andrew Burgess
@ 2013-08-02 11:12 ` Pedro Alves
0 siblings, 0 replies; 2+ messages in thread
From: Pedro Alves @ 2013-08-02 11:12 UTC (permalink / raw)
To: Andrew Burgess; +Cc: gdb-patches
On 08/02/2013 11:30 AM, Andrew Burgess wrote:
> Committed this patch to remove a duplicate call to add_file_handler,
> the call to gdb_setup_readline will have performed the same call for
> us.
>
> I hope this ok to commit as obvious without review.
It's fine, thanks.
--
Pedro Alves
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-02 11:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-02 10:31 [commit] [OBV] Remove duplicate call to add_file_handler Andrew Burgess
2013-08-02 11:12 ` Pedro Alves
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox