Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Andrew Burgess" <aburgess@broadcom.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [commit] [OBV] Remove duplicate call to add_file_handler
Date: Fri, 02 Aug 2013 10:31:00 -0000	[thread overview]
Message-ID: <51FB8A54.7060508@broadcom.com> (raw)

Committed this patch to remove a duplicate call to add_file_handler,
the call to gdb_setup_readline will have performed the same call for
us.

I hope this ok to commit as obvious without review.

Thanks,
Andrew

2013-08-02  Andrew Burgess  <aburgess@broadcom.com>

	* mi/mi-interp.c (mi_interpreter_resume): Remove call to
	add_file_handler.

diff -u -p -r1.84 mi-interp.c
--- ./gdb/mi/mi-interp.c        12 Mar 2013 18:50:39 -0000      1.84
+++ ./gdb/mi/mi-interp.c        2 Aug 2013 10:24:30 -0000
@@ -169,7 +169,6 @@ mi_interpreter_resume (void *data)
      _intialize_event_loop.  */
   call_readline = gdb_readline2;
   input_handler = mi_execute_command_input_handler;
-  add_file_handler (input_fd, stdin_event_handler, 0);
   async_command_editing_p = 0;
   /* FIXME: This is a total hack for now.  PB's use of the MI
      implicitly relies on a bug in the async support which allows


             reply	other threads:[~2013-08-02 10:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-02 10:31 Andrew Burgess [this message]
2013-08-02 11:12 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51FB8A54.7060508@broadcom.com \
    --to=aburgess@broadcom.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox