Re: [PATCH 17/17] MIPS support

[Pedro Alves <palves@redhat.com>]

On 07/25/2013 07:19 AM, Sergio Durigan Junior wrote:
> On Wednesday, July 17 2013, Tom Tromey wrote:
> 
>>>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
>>
>> Sergio> MIPS already has a definition of its signals inside mips-linux-tdep.h
>> Sergio> (see enum mips_signals).  I could have used them, but I chose to
>> Sergio> follow the standard and implement an enum containing only differences
>> Sergio> between MIPS and x86 signals.  In the battle between code duplication
>> Sergio> and code standardization, the latter won (in my head, at least).  But I
>> Sergio> am totally open to suggestions, and I even believe I know what I will
>> Sergio> hear: "Please, use mips_signals".
>>
>> Sergio> Anyway, I thought it was worth raising this point here.
>>
>> Thanks.
>>
>> One thing I'm curious about is why the corresponding
>> gdbarch_gdb_signal_from_target method is only implemented for MIPS, and
>> not for all Linux targets.
> 
> Thanks for the review.
> 
> The gdbarch_gdb_signal_from_target method for MIPS was introduced by:
> 
> <http://sourceware.org/ml/gdb-patches/2012-06/msg00048.html>
> 
> As far as I can tell, nobody really cared about implementing it for
> other architectures.  So far.
> 
> I now have a patch which does that for the same architectures that I am
> touching to implement the gdbarch_gdb_signal_to_target method, and I
> will submit it along with the other patches.

Nice.  That'll get us further along the
core-debugging-should-be-host-independent idea.  That fits nicely
along earlier prpsinfo bfd work in that direction too.  :-)  Hmm,
maybe we should have a wiki page for that whole project.

-- 
Pedro Alves