From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31671 invoked by alias); 29 Jul 2013 20:15:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31660 invoked by uid 89); 29 Jul 2013 20:15:07 -0000 X-Spam-SWARE-Status: No, score=-6.0 required=5.0 tests=AWL,BAYES_40,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 29 Jul 2013 20:15:07 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6TKExxu004940 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 29 Jul 2013 16:14:59 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r6TKEwGh024884; Mon, 29 Jul 2013 16:14:58 -0400 Message-ID: <51F6CD41.6050600@redhat.com> Date: Mon, 29 Jul 2013 20:15:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Sergio Durigan Junior CC: Tom Tromey , GDB Patches Subject: Re: [PATCH 17/17] MIPS support References: <1372664545-3947-1-git-send-email-sergiodj@redhat.com> <1372664545-3947-18-git-send-email-sergiodj@redhat.com> <8738rdgj8p.fsf@fleche.redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-07/txt/msg00744.txt.bz2 On 07/25/2013 07:19 AM, Sergio Durigan Junior wrote: > On Wednesday, July 17 2013, Tom Tromey wrote: > >>>>>>> "Sergio" == Sergio Durigan Junior writes: >> >> Sergio> MIPS already has a definition of its signals inside mips-linux-tdep.h >> Sergio> (see enum mips_signals). I could have used them, but I chose to >> Sergio> follow the standard and implement an enum containing only differences >> Sergio> between MIPS and x86 signals. In the battle between code duplication >> Sergio> and code standardization, the latter won (in my head, at least). But I >> Sergio> am totally open to suggestions, and I even believe I know what I will >> Sergio> hear: "Please, use mips_signals". >> >> Sergio> Anyway, I thought it was worth raising this point here. >> >> Thanks. >> >> One thing I'm curious about is why the corresponding >> gdbarch_gdb_signal_from_target method is only implemented for MIPS, and >> not for all Linux targets. > > Thanks for the review. > > The gdbarch_gdb_signal_from_target method for MIPS was introduced by: > > > > As far as I can tell, nobody really cared about implementing it for > other architectures. So far. > > I now have a patch which does that for the same architectures that I am > touching to implement the gdbarch_gdb_signal_to_target method, and I > will submit it along with the other patches. Nice. That'll get us further along the core-debugging-should-be-host-independent idea. That fits nicely along earlier prpsinfo bfd work in that direction too. :-) Hmm, maybe we should have a wiki page for that whole project. -- Pedro Alves