Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: "gp >> \"gdb-patches@sourceware.org ml\"" <gdb-patches@sourceware.org>
Subject: [RFA] Fix mi-var-child-f.exp failures
Date: Thu, 25 Jul 2013 23:58:00 -0000	[thread overview]
Message-ID: <51F1BB9A.6050607@redhat.com> (raw)

Hi,

This test file contains three "new" failures which are actually not 
failures. They've been failing ever since dynamic varobjs went in:

commit 8e8a4e3d9ea92ce53f8d5373b1b8865c9c92636b
Author: Tom Tromey <tromey@redhat.com>
Date:   Tue Sep 15 18:51:24 2009 +0000

As a result of this commit, MI will now output a "has_more" attribute to 
-var-create, -var-update, and -var-list-children. The commit caught most 
of the places in the test suite where this needed to be added, but not 
many of us appear to have a fortran compiler installed, so 
mi-var-child-f.exp was overlooked.

I've chosen to fix as much of these tests by using standard test 
procedures (mi_create_varobj and mi_list_varobj_children) when possible.

Ok?
Keith

testsuite/ChangeLog
2013-07-25  Keith Seitz  <keiths@redhat.com>

	* gdb.mi/mi-var-child-f.exp: Use mi_create_varobj.
	Use mi_list_varobj_children for the immediate children of `array'.
	Add "has_more" attribute for grandchildren test.


diff --git a/gdb/testsuite/gdb.mi/mi-var-child-f.exp 
b/gdb/testsuite/gdb.mi/mi-var-child-f.exp
index 762a90d..c725871 100644
--- a/gdb/testsuite/gdb.mi/mi-var-child-f.exp
+++ b/gdb/testsuite/gdb.mi/mi-var-child-f.exp
@@ -37,14 +37,14 @@ mi_gdb_load ${binfile}

  mi_runto MAIN__

-mi_gdb_test "-var-create array * array" \
-    "\\^done,name=\"array\",numchild=\"3\",value=\".*\",type=\"integer 
\\(2,-1:1\\)\"" \
-    "create local variable array"
+mi_create_varobj "array" "array" "create local variable array"

-mi_gdb_test "-var-list-children --all-values array" \
- 
"\\^done,numchild=\"3\",children=\\\[child=\{name=\"array.-1\",exp=\"-1\",numchild=\"2\",value=\"\\\[2\\\]\",type=\"integer 
\\(2\\)\"\},child=\{name=\"array.0\",exp=\"0\",numchild=\"2\",value=\"\\\[2\\\]\",type=\"integer 
\\(2\\)\"\},child=\{name=\"array.1\",exp=\"1\",numchild=\"2\",value=\"\\\[2\\\]\",type=\"integer 
\\(2\\)\"\}\\\]" \
-    "get children of array"
+mi_list_varobj_children "array" {
+    {"array.-1" "-1" 2 "integer \\(2\\)"}
+    {"array.0" "0" 2 "integer \\(2\\)"}
+    {"array.1" "1" 2 "integer \\(2\\)"}
+} "get children of array"

  mi_gdb_test "-var-list-children --all-values array.-1" \
- 
"\\^done,numchild=\"2\",children=\\\[child=\{name=\"array.-1.1\",exp=\"1\",numchild=\"0\",value=\"11\",type=\"integer\"\},child=\{name=\"array.-1.2\",exp=\"2\",numchild=\"0\",value=\"21\",type=\"integer\"\}\\\]" 
\
+ 
"\\^done,numchild=\"2\",children=\\\[child=\{name=\"array.-1.1\",exp=\"1\",numchild=\"0\",value=\"11\",type=\"integer\"\},child=\{name=\"array.-1.2\",exp=\"2\",numchild=\"0\",value=\"21\",type=\"integer\"\}\\\],has_more=\"0\"" 
\
      "get grandchildren of array (children of first element of second 
index)"


             reply	other threads:[~2013-07-25 23:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-25 23:58 Keith Seitz [this message]
2013-07-26 14:23 ` Tom Tromey
2013-07-26 15:08   ` Keith Seitz
2013-07-26 16:30     ` Tom Tromey
2013-07-26 18:16       ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F1BB9A.6050607@redhat.com \
    --to=keiths@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox