From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13009 invoked by alias); 25 Jul 2013 23:58:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12887 invoked by uid 89); 25 Jul 2013 23:58:26 -0000 X-Spam-SWARE-Status: No, score=-5.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 25 Jul 2013 23:58:26 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6PNwIf6018628 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 25 Jul 2013 19:58:19 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r6PNwI02032007 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Thu, 25 Jul 2013 19:58:18 -0400 Message-ID: <51F1BB9A.6050607@redhat.com> Date: Thu, 25 Jul 2013 23:58:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: "gp >> \"gdb-patches@sourceware.org ml\"" Subject: [RFA] Fix mi-var-child-f.exp failures Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-07/txt/msg00632.txt.bz2 Hi, This test file contains three "new" failures which are actually not failures. They've been failing ever since dynamic varobjs went in: commit 8e8a4e3d9ea92ce53f8d5373b1b8865c9c92636b Author: Tom Tromey Date: Tue Sep 15 18:51:24 2009 +0000 As a result of this commit, MI will now output a "has_more" attribute to -var-create, -var-update, and -var-list-children. The commit caught most of the places in the test suite where this needed to be added, but not many of us appear to have a fortran compiler installed, so mi-var-child-f.exp was overlooked. I've chosen to fix as much of these tests by using standard test procedures (mi_create_varobj and mi_list_varobj_children) when possible. Ok? Keith testsuite/ChangeLog 2013-07-25 Keith Seitz * gdb.mi/mi-var-child-f.exp: Use mi_create_varobj. Use mi_list_varobj_children for the immediate children of `array'. Add "has_more" attribute for grandchildren test. diff --git a/gdb/testsuite/gdb.mi/mi-var-child-f.exp b/gdb/testsuite/gdb.mi/mi-var-child-f.exp index 762a90d..c725871 100644 --- a/gdb/testsuite/gdb.mi/mi-var-child-f.exp +++ b/gdb/testsuite/gdb.mi/mi-var-child-f.exp @@ -37,14 +37,14 @@ mi_gdb_load ${binfile} mi_runto MAIN__ -mi_gdb_test "-var-create array * array" \ - "\\^done,name=\"array\",numchild=\"3\",value=\".*\",type=\"integer \\(2,-1:1\\)\"" \ - "create local variable array" +mi_create_varobj "array" "array" "create local variable array" -mi_gdb_test "-var-list-children --all-values array" \ - "\\^done,numchild=\"3\",children=\\\[child=\{name=\"array.-1\",exp=\"-1\",numchild=\"2\",value=\"\\\[2\\\]\",type=\"integer \\(2\\)\"\},child=\{name=\"array.0\",exp=\"0\",numchild=\"2\",value=\"\\\[2\\\]\",type=\"integer \\(2\\)\"\},child=\{name=\"array.1\",exp=\"1\",numchild=\"2\",value=\"\\\[2\\\]\",type=\"integer \\(2\\)\"\}\\\]" \ - "get children of array" +mi_list_varobj_children "array" { + {"array.-1" "-1" 2 "integer \\(2\\)"} + {"array.0" "0" 2 "integer \\(2\\)"} + {"array.1" "1" 2 "integer \\(2\\)"} +} "get children of array" mi_gdb_test "-var-list-children --all-values array.-1" \ - "\\^done,numchild=\"2\",children=\\\[child=\{name=\"array.-1.1\",exp=\"1\",numchild=\"0\",value=\"11\",type=\"integer\"\},child=\{name=\"array.-1.2\",exp=\"2\",numchild=\"0\",value=\"21\",type=\"integer\"\}\\\]" \ + "\\^done,numchild=\"2\",children=\\\[child=\{name=\"array.-1.1\",exp=\"1\",numchild=\"0\",value=\"11\",type=\"integer\"\},child=\{name=\"array.-1.2\",exp=\"2\",numchild=\"0\",value=\"21\",type=\"integer\"\}\\\],has_more=\"0\"" \ "get grandchildren of array (children of first element of second index)"