From: Keith Seitz <keiths@redhat.com>
To: "gp >> \"gdb-patches@sourceware.org ml\"" <gdb-patches@sourceware.org>
Subject: Re: [RFA] Fix mi-var-child-f.exp failures
Date: Fri, 26 Jul 2013 18:16:00 -0000 [thread overview]
Message-ID: <51F2BCEC.9040204@redhat.com> (raw)
In-Reply-To: <87hafhthbj.fsf@fleche.redhat.com>
On 07/26/2013 09:30 AM, Tom Tromey wrote:
> Keith> 2013-07-26 Keith Seitz <keiths@redhat.com>
>
> Keith> * gdb.mi/mi-var-child-f.exp: Pass f90 to gdb_compile instead
> Keith> of f77.
> Keith> Allow for compiler variations of integer types.
> Keith> Use mi_create_varobj.
> Keith> Use mi_list_varobj_children for the immediate children of `array'.
> Keith> Add "has_more" attribute for grandchildren test.
>
> This is ok.
Committed.
> Keith> +# Depending on the compiler version being used, the name of the
> Keith> 4-byte integer
>
> Your patch got wrapped.
Yeah. Sometimes I cut-n-paste small patches like this. That's why I
usually use attachments.
Thank you for your review.
Keith
prev parent reply other threads:[~2013-07-26 18:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 23:58 Keith Seitz
2013-07-26 14:23 ` Tom Tromey
2013-07-26 15:08 ` Keith Seitz
2013-07-26 16:30 ` Tom Tromey
2013-07-26 18:16 ` Keith Seitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F2BCEC.9040204@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox