From: Stan Shebs <stanshebs@earthlink.net>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH, testsuite] Don't run SREC, IHEX and TEKHEX tests for MIPS N64.
Date: Tue, 02 Jul 2013 17:19:00 -0000 [thread overview]
Message-ID: <51D30BB0.3050906@earthlink.net> (raw)
In-Reply-To: <51D3050C.4070309@codesourcery.com>
On 7/2/13 9:51 AM, Luis Machado wrote:
> On 07/02/2013 01:47 PM, Tom Tromey wrote:
>>>>>>> "Luis" == Luis Machado <lgustavo@codesourcery.com> writes:
>>
>> Luis> Skipping this test for MIPS is not the right thing as some ABI's
>> are
>> Luis> 32-bit and so should be tested against the usual set of SREC,
>> IHEX and
>> Luis> TEKHEX formats.
>>
>> Luis> The attached patch checks for the N64 ABI and sets the internal
>> flag
>> Luis> is64bitonly accordingly, skipping the SREC, IHEX and TEKHEX tests.
>>
>> Should this be made more generic?
>> Say, test for "sizeof(&main) != 4"?
>
> It could be, if we can guarantee oddball architectures don't use
> pointers and addresses of strange sizes, say, an arch that declares
> function pointers of 4 bytes.
You could test both a function address and a data address, and if either
is greater than 4 bytes, the old formats can be excluded from testing.
Stan
stan@codesourcery.com
next prev parent reply other threads:[~2013-07-02 17:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-01 16:24 Luis Machado
2013-07-02 14:37 ` Yao Qi
2013-07-02 14:45 ` Luis Machado
2013-07-03 0:03 ` Yao Qi
2013-07-02 16:47 ` Tom Tromey
2013-07-02 16:51 ` Luis Machado
2013-07-02 17:19 ` Stan Shebs [this message]
2013-07-02 18:10 ` Tom Tromey
2013-07-02 18:50 ` Luis Machado
2013-07-02 20:55 ` Tom Tromey
2013-07-03 15:05 ` Pedro Alves
2013-07-03 19:23 ` Luis Machado
2013-07-03 19:26 ` Pedro Alves
2013-07-03 20:19 ` Luis Machado
2013-07-04 8:11 ` Pedro Alves
2013-07-06 2:41 ` Luis Machado
2013-07-03 20:35 ` Maciej W. Rozycki
2013-07-03 20:54 ` Luis Machado
2013-07-03 21:08 ` Maciej W. Rozycki
2013-07-04 11:48 ` Luis Machado
2013-07-04 12:13 ` Maciej W. Rozycki
2013-07-04 12:21 ` Luis Machado
2013-07-04 13:22 ` Ulrich Weigand
2013-07-04 13:24 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D30BB0.3050906@earthlink.net \
--to=stanshebs@earthlink.net \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox