From: Luis Machado <lgustavo@codesourcery.com>
To: "'gdb-patches@sourceware.org'" <gdb-patches@sourceware.org>
Subject: [PATCH, testsuite] Don't run SREC, IHEX and TEKHEX tests for MIPS N64.
Date: Mon, 01 Jul 2013 16:24:00 -0000 [thread overview]
Message-ID: <51D1AD43.3060904@codesourcery.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 483 bytes --]
Hi,
The gdb.base/dump.exp test had a few failures for MIPS N64. That is
expected since SREC, IHEX and TEKHEX dump formats don't support 64-bit
addresses, and MIPS N64 uses them.
Skipping this test for MIPS is not the right thing as some ABI's are
32-bit and so should be tested against the usual set of SREC, IHEX and
TEKHEX formats.
The attached patch checks for the N64 ABI and sets the internal flag
is64bitonly accordingly, skipping the SREC, IHEX and TEKHEX tests.
Ok?
[-- Attachment #2: dump_mips.diff --]
[-- Type: text/x-patch, Size: 1048 bytes --]
2013-07-01 Luis Machado <lgustavo@codesourcery.com>
* gdb.base/dump.exp: Don't run SREC, IHEX and TEKHEX dump
tests for mips N64 ABI.
Index: gdb/testsuite/gdb.base/dump.exp
===================================================================
--- gdb/testsuite/gdb.base/dump.exp (revision 415809)
+++ gdb/testsuite/gdb.base/dump.exp (working copy)
@@ -58,6 +58,17 @@
gdb_load ${binfile}
+# Since SREC, IHEX and TEKHEX cannot handle 64-bit addresses for
+# MIPS64, stop testing if we have a 64-bit MIPS program.
+if {[istarget "mips*-*-*"]} then {
+ send_gdb "show mips abi\n"
+ gdb_expect {
+ -re ".*n64.*$gdb_prompt $" {
+ set is64bitonly "yes"
+ }
+ }
+}
+
# Clean up any stale output files from previous test runs
remote_exec build "rm -f intarr1.bin intarr1b.bin intarr1.ihex intarr1.srec intarr1.tekhex intarr2.bin intarr2b.bin intarr2.ihex intarr2.srec intarr2.tekhex intstr1.bin intstr1b.bin intstr1.ihex intstr1.srec intstr1.tekhex intstr2.bin intstr2b.bin intstr2.ihex intstr2.srec intstr2.tekhex intarr3.srec"
next reply other threads:[~2013-07-01 16:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-01 16:24 Luis Machado [this message]
2013-07-02 14:37 ` Yao Qi
2013-07-02 14:45 ` Luis Machado
2013-07-03 0:03 ` Yao Qi
2013-07-02 16:47 ` Tom Tromey
2013-07-02 16:51 ` Luis Machado
2013-07-02 17:19 ` Stan Shebs
2013-07-02 18:10 ` Tom Tromey
2013-07-02 18:50 ` Luis Machado
2013-07-02 20:55 ` Tom Tromey
2013-07-03 15:05 ` Pedro Alves
2013-07-03 19:23 ` Luis Machado
2013-07-03 19:26 ` Pedro Alves
2013-07-03 20:19 ` Luis Machado
2013-07-04 8:11 ` Pedro Alves
2013-07-06 2:41 ` Luis Machado
2013-07-03 20:35 ` Maciej W. Rozycki
2013-07-03 20:54 ` Luis Machado
2013-07-03 21:08 ` Maciej W. Rozycki
2013-07-04 11:48 ` Luis Machado
2013-07-04 12:13 ` Maciej W. Rozycki
2013-07-04 12:21 ` Luis Machado
2013-07-04 13:22 ` Ulrich Weigand
2013-07-04 13:24 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D1AD43.3060904@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox