From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4663 invoked by alias); 1 Jul 2013 16:24:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4617 invoked by uid 89); 1 Jul 2013 16:24:40 -0000 X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 01 Jul 2013 16:24:39 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1Utgu6-0003I4-7K from Luis_Gustavo@mentor.com for gdb-patches@sourceware.org; Mon, 01 Jul 2013 09:24:38 -0700 Received: from NA1-MAIL.mgc.mentorg.com ([147.34.98.181]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 1 Jul 2013 09:24:38 -0700 Received: from [172.30.15.158] ([172.30.15.158]) by NA1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 1 Jul 2013 09:24:37 -0700 Message-ID: <51D1AD43.3060904@codesourcery.com> Date: Mon, 01 Jul 2013 16:24:00 -0000 From: Luis Machado Reply-To: lgustavo@codesourcery.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: "'gdb-patches@sourceware.org'" Subject: [PATCH, testsuite] Don't run SREC, IHEX and TEKHEX tests for MIPS N64. Content-Type: multipart/mixed; boundary="------------000409050506060504060803" X-Virus-Found: No X-SW-Source: 2013-07/txt/msg00044.txt.bz2 This is a multi-part message in MIME format. --------------000409050506060504060803 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 483 Hi, The gdb.base/dump.exp test had a few failures for MIPS N64. That is expected since SREC, IHEX and TEKHEX dump formats don't support 64-bit addresses, and MIPS N64 uses them. Skipping this test for MIPS is not the right thing as some ABI's are 32-bit and so should be tested against the usual set of SREC, IHEX and TEKHEX formats. The attached patch checks for the N64 ABI and sets the internal flag is64bitonly accordingly, skipping the SREC, IHEX and TEKHEX tests. Ok? --------------000409050506060504060803 Content-Type: text/x-patch; name="dump_mips.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="dump_mips.diff" Content-length: 1048 2013-07-01 Luis Machado * gdb.base/dump.exp: Don't run SREC, IHEX and TEKHEX dump tests for mips N64 ABI. Index: gdb/testsuite/gdb.base/dump.exp =================================================================== --- gdb/testsuite/gdb.base/dump.exp (revision 415809) +++ gdb/testsuite/gdb.base/dump.exp (working copy) @@ -58,6 +58,17 @@ gdb_load ${binfile} +# Since SREC, IHEX and TEKHEX cannot handle 64-bit addresses for +# MIPS64, stop testing if we have a 64-bit MIPS program. +if {[istarget "mips*-*-*"]} then { + send_gdb "show mips abi\n" + gdb_expect { + -re ".*n64.*$gdb_prompt $" { + set is64bitonly "yes" + } + } +} + # Clean up any stale output files from previous test runs remote_exec build "rm -f intarr1.bin intarr1b.bin intarr1.ihex intarr1.srec intarr1.tekhex intarr2.bin intarr2b.bin intarr2.ihex intarr2.srec intarr2.tekhex intstr1.bin intstr1b.bin intstr1.ihex intstr1.srec intstr1.tekhex intstr2.bin intstr2b.bin intstr2.ihex intstr2.srec intstr2.tekhex intarr3.srec" --------------000409050506060504060803--