From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6017 invoked by alias); 2 Jul 2013 17:19:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6007 invoked by uid 89); 2 Jul 2013 17:19:52 -0000 X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD autolearn=ham version=3.3.1 Received: from elasmtp-kukur.atl.sa.earthlink.net (HELO elasmtp-kukur.atl.sa.earthlink.net) (209.86.89.65) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 02 Jul 2013 17:19:51 +0000 Received: from [68.96.200.16] (helo=macbook2.local) by elasmtp-kukur.atl.sa.earthlink.net with esmtpa (Exim 4.67) (envelope-from ) id 1Uu4F2-0007C7-Om for gdb-patches@sourceware.org; Tue, 02 Jul 2013 13:19:49 -0400 Message-ID: <51D30BB0.3050906@earthlink.net> Date: Tue, 02 Jul 2013 17:19:00 -0000 From: Stan Shebs User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [PATCH, testsuite] Don't run SREC, IHEX and TEKHEX tests for MIPS N64. References: <51D1AD43.3060904@codesourcery.com> <8761wsgb8i.fsf@fleche.redhat.com> <51D3050C.4070309@codesourcery.com> In-Reply-To: <51D3050C.4070309@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-ELNK-Trace: ae6f8838ff913eba0cc1426638a40ef67e972de0d01da940656b3dd267c4962d5d089bdd3675df84350badd9bab72f9c350badd9bab72f9c350badd9bab72f9c X-SW-Source: 2013-07/txt/msg00084.txt.bz2 On 7/2/13 9:51 AM, Luis Machado wrote: > On 07/02/2013 01:47 PM, Tom Tromey wrote: >>>>>>> "Luis" == Luis Machado writes: >> >> Luis> Skipping this test for MIPS is not the right thing as some ABI's >> are >> Luis> 32-bit and so should be tested against the usual set of SREC, >> IHEX and >> Luis> TEKHEX formats. >> >> Luis> The attached patch checks for the N64 ABI and sets the internal >> flag >> Luis> is64bitonly accordingly, skipping the SREC, IHEX and TEKHEX tests. >> >> Should this be made more generic? >> Say, test for "sizeof(&main) != 4"? > > It could be, if we can guarantee oddball architectures don't use > pointers and addresses of strange sizes, say, an arch that declares > function pointers of 4 bytes. You could test both a function address and a data address, and if either is greater than 4 bytes, the old formats can be excluded from testing. Stan stan@codesourcery.com