Re: [PATCH v3] gdbserver: fix the standalone build

[Pedro Alves <palves@redhat.com>]

On 06/28/2013 01:17 PM, Yao Qi wrote:
> On 06/28/2013 07:59 PM, Mircea Gherzan wrote:
>> When directly invoking gdb/gdbserver/configure && make, the build will
>> fail because the $(host_alias) is empty and thus create-version.sh does
>> not get enough parameters.
>>
>> The output of gdbserver --version without this patch (built like above):
>>
>>    [...]
>>    This gdbserver was configured as ""
>>
>> After applying this patch:
>>
>>    [...]
>>    This gdbserver was configured as "x86_64-unknown-linux-gnu"
>>
>> Ok to commit?
>>
>> 2013-06-28  Mircea Gherzan<mircea.gherzan@intel.com>
>>
>> gdbserver:
>>
>> 	* configure.ac (version_host): Add it.
>> 	(version_host): Add it.
>> 	* configure: Rebuild.
>> 	* Makefile.in (version_host): Add it.
>> 	(version_target): Add it.
>> 	(version.c): Use $(version_host) and $(version_target).
> 
> If we commit this patch, probably my patch to common/create-version.sh 
> becomes useless, because 'target_alias' or 'target' will be always 
> passed to it.
> 
> 2013-06-27  Yao Qi  <yao@codesourcery.com>
> 
> 	* common/create-version.sh: Update comments.  Handle the case
> 	that TARGET_ALIAS is empty.
> 
> revert it?

Doesn't GDB, and whatever other users of create-version.h, need the
same treatment first?

-- 
Pedro Alves