From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9667 invoked by alias); 28 Jun 2013 12:28:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9655 invoked by uid 89); 28 Jun 2013 12:28:06 -0000 X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 28 Jun 2013 12:28:05 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5SCN2nF010343 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 28 Jun 2013 08:23:02 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5SCN07G009355; Fri, 28 Jun 2013 08:23:00 -0400 Message-ID: <51CD8023.3030308@redhat.com> Date: Fri, 28 Jun 2013 12:43:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Yao Qi CC: Mircea Gherzan , tromey@redhat.com, gdb-patches@sourceware.org Subject: Re: [PATCH v3] gdbserver: fix the standalone build References: <1372420771-942-1-git-send-email-mircea.gherzan@intel.com> <51CD7ED4.6070104@codesourcery.com> In-Reply-To: <51CD7ED4.6070104@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00878.txt.bz2 On 06/28/2013 01:17 PM, Yao Qi wrote: > On 06/28/2013 07:59 PM, Mircea Gherzan wrote: >> When directly invoking gdb/gdbserver/configure && make, the build will >> fail because the $(host_alias) is empty and thus create-version.sh does >> not get enough parameters. >> >> The output of gdbserver --version without this patch (built like above): >> >> [...] >> This gdbserver was configured as "" >> >> After applying this patch: >> >> [...] >> This gdbserver was configured as "x86_64-unknown-linux-gnu" >> >> Ok to commit? >> >> 2013-06-28 Mircea Gherzan >> >> gdbserver: >> >> * configure.ac (version_host): Add it. >> (version_host): Add it. >> * configure: Rebuild. >> * Makefile.in (version_host): Add it. >> (version_target): Add it. >> (version.c): Use $(version_host) and $(version_target). > > If we commit this patch, probably my patch to common/create-version.sh > becomes useless, because 'target_alias' or 'target' will be always > passed to it. > > 2013-06-27 Yao Qi > > * common/create-version.sh: Update comments. Handle the case > that TARGET_ALIAS is empty. > > revert it? Doesn't GDB, and whatever other users of create-version.h, need the same treatment first? -- Pedro Alves