Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: Mircea Gherzan <mircea.gherzan@intel.com>
Cc: <tromey@redhat.com>, <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH v3] gdbserver: fix the standalone build
Date: Fri, 28 Jun 2013 12:18:00 -0000	[thread overview]
Message-ID: <51CD7ED4.6070104@codesourcery.com> (raw)
In-Reply-To: <1372420771-942-1-git-send-email-mircea.gherzan@intel.com>

On 06/28/2013 07:59 PM, Mircea Gherzan wrote:
> When directly invoking gdb/gdbserver/configure && make, the build will
> fail because the $(host_alias) is empty and thus create-version.sh does
> not get enough parameters.
>
> The output of gdbserver --version without this patch (built like above):
>
>    [...]
>    This gdbserver was configured as ""
>
> After applying this patch:
>
>    [...]
>    This gdbserver was configured as "x86_64-unknown-linux-gnu"
>
> Ok to commit?
>
> 2013-06-28  Mircea Gherzan<mircea.gherzan@intel.com>
>
> gdbserver:
>
> 	* configure.ac (version_host): Add it.
> 	(version_host): Add it.
> 	* configure: Rebuild.
> 	* Makefile.in (version_host): Add it.
> 	(version_target): Add it.
> 	(version.c): Use $(version_host) and $(version_target).

If we commit this patch, probably my patch to common/create-version.sh 
becomes useless, because 'target_alias' or 'target' will be always 
passed to it.

2013-06-27  Yao Qi  <yao@codesourcery.com>

	* common/create-version.sh: Update comments.  Handle the case
	that TARGET_ALIAS is empty.

revert it?

-- 
Yao (齐尧)


  reply	other threads:[~2013-06-28 12:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-28 12:05 Mircea Gherzan
2013-06-28 12:18 ` Yao Qi [this message]
2013-06-28 12:43   ` Pedro Alves
2013-06-29  3:11     ` Yao Qi
2013-07-01 15:39       ` Pedro Alves
2013-07-03 15:04         ` Yao Qi
2013-07-03 15:11           ` Yao Qi
2013-07-03 15:19             ` Pedro Alves
2013-07-04  1:27               ` Yao Qi
2013-06-28 12:18 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51CD7ED4.6070104@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mircea.gherzan@intel.com \
    --cc=palves@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox