From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31982 invoked by alias); 28 Jun 2013 12:18:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31850 invoked by uid 89); 28 Jun 2013 12:17:57 -0000 X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 28 Jun 2013 12:17:56 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UsXcg-0005dD-69 from Yao_Qi@mentor.com ; Fri, 28 Jun 2013 05:17:54 -0700 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Fri, 28 Jun 2013 05:17:53 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.2.247.3; Fri, 28 Jun 2013 05:17:53 -0700 Message-ID: <51CD7ED4.6070104@codesourcery.com> Date: Fri, 28 Jun 2013 12:18:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Mircea Gherzan CC: , , Subject: Re: [PATCH v3] gdbserver: fix the standalone build References: <1372420771-942-1-git-send-email-mircea.gherzan@intel.com> In-Reply-To: <1372420771-942-1-git-send-email-mircea.gherzan@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-06/txt/msg00876.txt.bz2 On 06/28/2013 07:59 PM, Mircea Gherzan wrote: > When directly invoking gdb/gdbserver/configure && make, the build will > fail because the $(host_alias) is empty and thus create-version.sh does > not get enough parameters. > > The output of gdbserver --version without this patch (built like above): > > [...] > This gdbserver was configured as "" > > After applying this patch: > > [...] > This gdbserver was configured as "x86_64-unknown-linux-gnu" > > Ok to commit? > > 2013-06-28 Mircea Gherzan > > gdbserver: > > * configure.ac (version_host): Add it. > (version_host): Add it. > * configure: Rebuild. > * Makefile.in (version_host): Add it. > (version_target): Add it. > (version.c): Use $(version_host) and $(version_target). If we commit this patch, probably my patch to common/create-version.sh becomes useless, because 'target_alias' or 'target' will be always passed to it. 2013-06-27 Yao Qi * common/create-version.sh: Update comments. Handle the case that TARGET_ALIAS is empty. revert it? -- Yao (齐尧)