From: Pedro Alves <palves@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] ChangeLog width 74 -> 80
Date: Tue, 18 Jun 2013 15:30:00 -0000 [thread overview]
Message-ID: <51C07B94.3080606@redhat.com> (raw)
In-Reply-To: <20130618150401.GA24795@host2.jankratochvil.net>
On 06/18/2013 04:04 PM, Jan Kratochvil wrote:
> Hi,
>
> currently ChangeLog has Emacs rule for 74 columns which is also documented at:
> http://sourceware.org/gdb/wiki/ContributionChecklist
> ChangeLog standard max-line-length is 74.
>
> Plus code comments should be formatted to 72 columns (unwritten rule,
> I haven't found it anywhere) and code should be formatted to 80 columns.
>
> One has to reconfigure editor several times a minute, what about unifying
> everything to 80 columns (including the comments formatting). 80 columns is
> already a narrow column on the left of the screen on displays nowadays.
I really don't care that much about the precise width, but
I'll note that 74 is hardcoded in most if not all ChangeLogs
in the src tree:
$ find . -name "ChangeLog*" | xargs grep fill-colu | wc -l
79
It may be simpler to go with the flow than coming up with
an exception...
74 is the default column width in emacs' changelog mode,
so it seems the explicit setting is just trying to making
sure everyone (that uses emacs) is using the default width,
even if one has it overridden in their .emacs file.
--
Pedro Alves
next prev parent reply other threads:[~2013-06-18 15:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 15:09 Jan Kratochvil
2013-06-18 15:30 ` Pedro Alves [this message]
2013-06-18 15:34 ` Jan Kratochvil
2013-06-18 15:47 ` Pedro Alves
2013-06-18 15:51 ` Jan Kratochvil
2013-06-18 16:22 ` Pedro Alves
2013-06-18 18:02 ` Jan Kratochvil
2013-06-18 21:35 ` Joel Brobecker
2013-06-19 13:25 ` [cancel] " Jan Kratochvil
2013-06-19 7:50 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C07B94.3080606@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox