From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24785 invoked by alias); 18 Jun 2013 15:24:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24763 invoked by uid 89); 18 Jun 2013 15:24:08 -0000 X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 18 Jun 2013 15:24:08 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5IFO67p029119 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 18 Jun 2013 11:24:06 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5IFO5Fn019892; Tue, 18 Jun 2013 11:24:05 -0400 Message-ID: <51C07B94.3080606@redhat.com> Date: Tue, 18 Jun 2013 15:30:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Jan Kratochvil CC: gdb-patches@sourceware.org Subject: Re: [patch] ChangeLog width 74 -> 80 References: <20130618150401.GA24795@host2.jankratochvil.net> In-Reply-To: <20130618150401.GA24795@host2.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00424.txt.bz2 On 06/18/2013 04:04 PM, Jan Kratochvil wrote: > Hi, > > currently ChangeLog has Emacs rule for 74 columns which is also documented at: > http://sourceware.org/gdb/wiki/ContributionChecklist > ChangeLog standard max-line-length is 74. > > Plus code comments should be formatted to 72 columns (unwritten rule, > I haven't found it anywhere) and code should be formatted to 80 columns. > > One has to reconfigure editor several times a minute, what about unifying > everything to 80 columns (including the comments formatting). 80 columns is > already a narrow column on the left of the screen on displays nowadays. I really don't care that much about the precise width, but I'll note that 74 is hardcoded in most if not all ChangeLogs in the src tree: $ find . -name "ChangeLog*" | xargs grep fill-colu | wc -l 79 It may be simpler to go with the flow than coming up with an exception... 74 is the default column width in emacs' changelog mode, so it seems the explicit setting is just trying to making sure everyone (that uses emacs) is using the default width, even if one has it overridden in their .emacs file. -- Pedro Alves