From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] ChangeLog width 74 -> 80
Date: Tue, 18 Jun 2013 18:02:00 -0000 [thread overview]
Message-ID: <20130618175322.GA490@host2.jankratochvil.net> (raw)
In-Reply-To: <51C08639.4080506@redhat.com>
On Tue, 18 Jun 2013 18:09:29 +0200, Pedro Alves wrote:
> The patch does:
>
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -7060,7 +7060,7 @@ For older changes see ChangeLog-2012.
> Local Variables:
> mode: change-log
> left-margin: 8
> -fill-column: 74
> +fill-column: 80
>
> You surely know that's an emacs setting.
The patch was there to update the Emacs setting as it would no longer match
the coding standard (if the 80 columns get approved).
I could also post an equivalent patch removing the Emacs setting instead.
But such patch would be more difficult to get through and it would be also
rather off-topic to what the mail was trying to do.
> >> As I said, I really don't care that much about the precise width.
> >> It'd be nice to have it changed consistently across the tree
> >> though.
> >
> > One should define first what is "the tree", currently it contains many
> > directions which seems irrelevant for GDB decisions to me (tcl, texinfo,
> > newlib, rda, ...).
>
> Sure, the things outside src/gdb/ that are part of gdb as well:
>
> src/, src/bfd/, src/include/, src/include/gdb/, etc.
OK, the tree from default CVS checkout of virtual directory "gdb".
> I'm all for consistency, so on my part, if this results in
> better consistency, go for it.
Great.
> Please update gdb/testsuite/ChangeLog gdb/doc/ChangeLog too though.
True. I will post a new patch.
Thanks,
Jan
next prev parent reply other threads:[~2013-06-18 17:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 15:09 Jan Kratochvil
2013-06-18 15:30 ` Pedro Alves
2013-06-18 15:34 ` Jan Kratochvil
2013-06-18 15:47 ` Pedro Alves
2013-06-18 15:51 ` Jan Kratochvil
2013-06-18 16:22 ` Pedro Alves
2013-06-18 18:02 ` Jan Kratochvil [this message]
2013-06-18 21:35 ` Joel Brobecker
2013-06-19 13:25 ` [cancel] " Jan Kratochvil
2013-06-19 7:50 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130618175322.GA490@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox