From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2080 invoked by alias); 18 Jun 2013 17:53:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2065 invoked by uid 89); 18 Jun 2013 17:53:29 -0000 X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 18 Jun 2013 17:53:28 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5IHrR8e006640 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 18 Jun 2013 13:53:27 -0400 Received: from host2.jankratochvil.net (ovpn-116-40.ams2.redhat.com [10.36.116.40]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5IHrNtm003531 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 18 Jun 2013 13:53:25 -0400 Date: Tue, 18 Jun 2013 18:02:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [patch] ChangeLog width 74 -> 80 Message-ID: <20130618175322.GA490@host2.jankratochvil.net> References: <20130618150401.GA24795@host2.jankratochvil.net> <51C07B94.3080606@redhat.com> <20130618153005.GA26742@host2.jankratochvil.net> <51C07FCC.6090706@redhat.com> <20130618154752.GA27499@host2.jankratochvil.net> <51C08639.4080506@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51C08639.4080506@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-06/txt/msg00445.txt.bz2 On Tue, 18 Jun 2013 18:09:29 +0200, Pedro Alves wrote: > The patch does: > > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -7060,7 +7060,7 @@ For older changes see ChangeLog-2012. > Local Variables: > mode: change-log > left-margin: 8 > -fill-column: 74 > +fill-column: 80 > > You surely know that's an emacs setting. The patch was there to update the Emacs setting as it would no longer match the coding standard (if the 80 columns get approved). I could also post an equivalent patch removing the Emacs setting instead. But such patch would be more difficult to get through and it would be also rather off-topic to what the mail was trying to do. > >> As I said, I really don't care that much about the precise width. > >> It'd be nice to have it changed consistently across the tree > >> though. > > > > One should define first what is "the tree", currently it contains many > > directions which seems irrelevant for GDB decisions to me (tcl, texinfo, > > newlib, rda, ...). > > Sure, the things outside src/gdb/ that are part of gdb as well: > > src/, src/bfd/, src/include/, src/include/gdb/, etc. OK, the tree from default CVS checkout of virtual directory "gdb". > I'm all for consistency, so on my part, if this results in > better consistency, go for it. Great. > Please update gdb/testsuite/ChangeLog gdb/doc/ChangeLog too though. True. I will post a new patch. Thanks, Jan