Re: [PATCH] Fix hardware watchpoints on PowerPC servers

[Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>]

On 05/13/2013 11:16 AM, Edjunior Barbosa Machado wrote:
> On 05/13/2013 10:19 AM, Ulrich Weigand wrote:
>> So the kernel now reports it supports PPC_DEBUG_FEATURE_DATA_BP_RANGE,
>> but then rejects any attempt to set a range BP of more than 8 bytes?
>> And there's no way to check for this ahead of time except for checking
>> the BookE hwcaps bits?   That seems unfortunate ...
>>
>> But I guess if that's the way the kernel interface is now, we'll have to
>> add that check.
> 
> Yes, unfortunately this is the info we have from the kernel interface.
> booke_debug_info.data_bp_alignment informs the alignment, which, in the
> case of current bookS processors, is also the max length for the
> watchpoint (8 bytes).
> 
>>
>>> 	* ppc-linux-nat.c (ppc_linux_region_ok_for_hw_watchpoint): Check if the
>>> 	region is ok for a hardware watchpoint using the new ptrace interface
>>> 	on Power servers.
>>
>> This is OK.
>>
>> As noted by Luis, it would be good to rename the "booke" terminology,
>> maybe using something like "have_ptrace_hwdebug" instead of
>> have_ptrace_booke_interface.  But that should be a separate patch.
> 
> I'll work on a patch following these suggestions you and Luis mentioned.
> 
> Thanks for the feedback, Ulrich.
> 

Checked in: http://sourceware.org/ml/gdb-cvs/2013-05/msg00146.html

Thanks.
-- 
Edjunior